Implement networkingPrivate.getDeviceStates

extensions/browser/api/networking_private/networking_private_delegate.h

Index: extensions/browser/api/networking_private/networking_private_delegate.h
diff --git a/extensions/browser/api/networking_private/networking_private_delegate.h b/extensions/browser/api/networking_private/networking_private_delegate.h
index bf75283be79bf664fec889d103c218c1f9c6318f..c023cd6c1d99d000d4c5ba85b37e522866e7db0d 100644
--- a/extensions/browser/api/networking_private/networking_private_delegate.h
+++ b/extensions/browser/api/networking_private/networking_private_delegate.h
@@ -31,15 +31,16 @@ struct VerificationProperties;
 // networking_private.idl for descriptions of the expected inputs and results.
 class NetworkingPrivateDelegate : public KeyedService {
  public:
-  typedef base::Callback<void(scoped_ptr<base::DictionaryValue>)>
-      DictionaryCallback;
-  typedef base::Callback<void()> VoidCallback;
-  typedef base::Callback<void(bool)> BoolCallback;
-  typedef base::Callback<void(const std::string&)> StringCallback;
-  typedef base::Callback<void(scoped_ptr<base::ListValue>)> NetworkListCallback;
-  typedef base::Callback<void(const std::string&)> FailureCallback;
-  typedef core_api::networking_private::VerificationProperties
-      VerificationProperties;
+  using DictionaryCallback =
+      base::Callback<void(scoped_ptr<base::DictionaryValue>)>;
+  using VoidCallback = base::Callback<void()>;
+  using BoolCallback = base::Callback<void(bool)>;
+  using StringCallback = base::Callback<void(const std::string&)>;
+  using NetworkListCallback = base::Callback<void(scoped_ptr<base::ListValue>)>;
+  using FailureCallback = base::Callback<void(const std::string&)>;
+  using DeviceStateMap = std::map<std::string, std::string>;

[pneubeck (no reviews), 2015/04/08 10:05:07]

please document what the keys and values are.

[stevenjb, 2015/04/08 20:27:30]

Documented with GetDeviceStates. I can rename the typedef if that helps.

+  using VerificationProperties =
+      core_api::networking_private::VerificationProperties;
 
   // The Verify* methods will be forwarded to a delegate implementation if
   // provided, otherwise they will fail. A separate delegate it used so that the
@@ -136,6 +137,9 @@ class NetworkingPrivateDelegate : public KeyedService {
   // Returns a list of ONC type strings.
   virtual scoped_ptr<base::ListValue> GetEnabledNetworkTypes() = 0;
 
+  // Returns a map of ONC network types to ONC device states.
+  virtual scoped_ptr<DeviceStateMap> GetDeviceStates() = 0;
+
   // Returns true if the ONC network type |type| is enabled.
   virtual bool EnableNetworkType(const std::string& type) = 0;