Implement networkingPrivate.getDeviceStates

extensions/browser/api/networking_private/networking_private_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_DELEGATE_H_
 #define EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_DELEGATE_H_
 
 #include <string>
 
 #include "base/callback.h"
@@ skipping 13 matching lines @@
 namespace networking_private {
 struct VerificationProperties;
 }  // networking_private
 }  // core_api
 
 // Base class for platform dependent networkingPrivate API implementations.
 // All inputs and results for this class use ONC values. See
 // networking_private.idl for descriptions of the expected inputs and results.
 class NetworkingPrivateDelegate : public KeyedService {
  public:
-  typedef base::Callback<void(scoped_ptr<base::DictionaryValue>)>
-      DictionaryCallback;
-  typedef base::Callback<void()> VoidCallback;
-  typedef base::Callback<void(bool)> BoolCallback;
-  typedef base::Callback<void(const std::string&)> StringCallback;
-  typedef base::Callback<void(scoped_ptr<base::ListValue>)> NetworkListCallback;
-  typedef base::Callback<void(const std::string&)> FailureCallback;
-  typedef core_api::networking_private::VerificationProperties
-      VerificationProperties;
+  using DictionaryCallback =
+      base::Callback<void(scoped_ptr<base::DictionaryValue>)>;
+  using VoidCallback = base::Callback<void()>;
+  using BoolCallback = base::Callback<void(bool)>;
+  using StringCallback = base::Callback<void(const std::string&)>;
+  using NetworkListCallback = base::Callback<void(scoped_ptr<base::ListValue>)>;
+  using FailureCallback = base::Callback<void(const std::string&)>;
+  using DeviceStateMap = std::map<std::string, std::string>;

[pneubeck (no reviews), 2015/04/08 10:05:07]

please document what the keys and values are.

[stevenjb, 2015/04/08 20:27:30]

Documented with GetDeviceStates. I can rename the typedef if that helps.

+  using VerificationProperties =
+      core_api::networking_private::VerificationProperties;
 
   // The Verify* methods will be forwarded to a delegate implementation if
   // provided, otherwise they will fail. A separate delegate it used so that the
   // current Verify* implementations are not exposed outside of src/chrome.
   class VerifyDelegate {
    public:
     typedef NetworkingPrivateDelegate::VerificationProperties
         VerificationProperties;
     typedef NetworkingPrivateDelegate::BoolCallback BoolCallback;
     typedef NetworkingPrivateDelegate::StringCallback StringCallback;
@@ skipping 76 matching lines @@
   virtual void GetCaptivePortalStatus(
       const std::string& guid,
       const StringCallback& success_callback,
       const FailureCallback& failure_callback) = 0;
 
   // Synchronous methods
 
   // Returns a list of ONC type strings.
   virtual scoped_ptr<base::ListValue> GetEnabledNetworkTypes() = 0;
 
+  // Returns a map of ONC network types to ONC device states.
+  virtual scoped_ptr<DeviceStateMap> GetDeviceStates() = 0;
+
   // Returns true if the ONC network type |type| is enabled.
   virtual bool EnableNetworkType(const std::string& type) = 0;
 
   // Returns true if the ONC network type |type| is disabled.
   virtual bool DisableNetworkType(const std::string& type) = 0;
 
   // Returns true if a scan was requested. It may take many seconds for a scan
   // to complete. The scan may or may not trigger API events when complete.
   virtual bool RequestScan() = 0;
 
@@ skipping 20 matching lines @@
  private:
   // Interface for Verify* methods. May be NULL.
   scoped_ptr<VerifyDelegate> verify_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateDelegate);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_API_NETWORKING_PRIVATE_NETWORKING_PRIVATE_DELEGATE_H_