Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: appengine/chromium_rietveld/codereview/buildbucket.py

Issue 1058893004: Rietveld schedules builds on buildbucket (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/chromium_rietveld/codereview/buildbucket.py
diff --git a/appengine/chromium_rietveld/codereview/buildbucket.py b/appengine/chromium_rietveld/codereview/buildbucket.py
index 282d5be92104f33693dd640370427977eb015018..1eed3acb942de759f8eee53328e7051bfdd58733 100644
--- a/appengine/chromium_rietveld/codereview/buildbucket.py
+++ b/appengine/chromium_rietveld/codereview/buildbucket.py
@@ -20,13 +20,10 @@ import logging
import os
import urllib
-from google.appengine.api import app_identity
from google.appengine.api import urlfetch
from google.appengine.api import users
from google.appengine.ext import ndb
-from django.conf import settings
-
from codereview import common
from codereview import models
@@ -140,13 +137,8 @@ class BuildbucketTryJobResult(models.TryJobResult):
)
-def get_self_hostname():
- """Returns hostname to use for buildset tag.
-
- See tag conventions http://cr-buildbucket.appspot.com/#docs/conventions
- """
- app_id = app_identity.get_application_id()
- return settings.PREFERRED_DOMAIN_NAMES.get(app_id)
+################################################################################
+## Gettings builds.
def get_builds_for_patchset(issue_id, patchset_id):
@@ -159,7 +151,7 @@ def get_builds_for_patchset(issue_id, patchset_id):
Returns:
A list of buildbucket build dicts.
"""
- hostname = get_self_hostname()
+ hostname = common.get_preferred_domain_name()
if not hostname:
logging.error(
'Preferred domain name for this app is not set. '

Powered by Google App Engine
This is Rietveld 408576698