Rietveld schedules builds on buildbucket

appengine/chromium_rietveld/codereview/buildbucket.py

 # Copyright 2008 Google Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
 """Rietveld-BuildBucket integration module."""
 
 import datetime
 import json
 import logging
 import os
 import urllib
 
-from google.appengine.api import app_identity
 from google.appengine.api import urlfetch
 from google.appengine.api import users
 from google.appengine.ext import ndb
 
-from django.conf import settings
-
 from codereview import common
 from codereview import models
 
 EPOCH = datetime.datetime.utcfromtimestamp(0)
 BUILDBUCKET_HOSTNAME = (
     'cr-buildbucket-test.appspot.com' if common.IS_DEV
     else 'cr-buildbucket.appspot.com')
 BUILDBUCKET_API_ROOT = (
     'https://%s/_ah/api/buildbucket/v1' % BUILDBUCKET_HOSTNAME)
 
@@ skipping 93 matching lines @@
         timestamp=timestamp,
         clobber=read_prop('clobber', bool),
         tests=read_prop('testfilter', list) or [],
         project=read_prop('project', basestring),
         requester=requester,
         category=read_prop('category', basestring),
         build_properties=json.dumps(properties, sort_keys=True),
     )
 
 
-def get_self_hostname():
-  """Returns hostname to use for buildset tag.
-
-  See tag conventions http://cr-buildbucket.appspot.com/#docs/conventions
-  """
-  app_id = app_identity.get_application_id()
-  return settings.PREFERRED_DOMAIN_NAMES.get(app_id)
+################################################################################
+## Gettings builds.
 
 
 def get_builds_for_patchset(issue_id, patchset_id):
   """Queries BuildBucket for builds associated with the patchset.
 
   Requests for max 500 builds and does not check "next_cursor". Currently if
   more than 100 builds are requested, only 100 are returned. Presumably there
   will be no patchsets with >100 builds.
 
   Returns:
     A list of buildbucket build dicts.
   """
-  hostname = get_self_hostname()
+  hostname = common.get_preferred_domain_name()
   if not hostname:
     logging.error(
         'Preferred domain name for this app is not set. '
         'See PREFERRED_DOMAIN_NAMES in settings.py')
     return []
 
   buildset_tag = BUILDSET_TAG_FORMAT.format(
       hostname=hostname,
       issue=issue_id,
       patch=patchset_id,
@@ skipping 72 matching lines @@
     return None
   return value
 
 
 def timestamp_to_datetime(timestamp):
   if timestamp is None:
     return None
   if isinstance(timestamp, basestring):
     timestamp = int(timestamp)
   return EPOCH + datetime.timedelta(microseconds=timestamp)