Move blink scheduler implementation into a component

Move blink scheduler implementation into a component

R=jam@chromium.org,skyostil@chromium.org,rmcilroy@chromium.org
BUG=477690
Committed: https://crrev.com/83c639f0493539896ac7c2e8db0ac93898955599
Cr-Commit-Position: refs/heads/master@{#326320}

[jochen (gone - plz use gerrit), 2015-04-21 14:28:22]

Ross, Sami: ptal

John: fyi (and I'd appreciate a rubberstamp for all the DEPS changes)

[jochen (gone - plz use gerrit), 2015-04-21 14:41:10]

guess I need to move scheduler.gypi to scheduler.gyp to make the non-component
build work

[rmcilroy, 2015-04-21 16:21:09]

A couple of comments but generally lgtm - thanks for doing the move! Please let
Sami have a look as well before committing though, thanks.

https://codereview.chromium.org/1058873010/diff/1/components/scheduler/BUILD.gn
File components/scheduler/BUILD.gn (right):

https://codereview.chromium.org/1058873010/diff/1/components/scheduler/BUILD....
components/scheduler/BUILD.gn:43: "scheduler_export.h",
Can we share the file list between GN and gyp?

https://codereview.chromium.org/1058873010/diff/1/components/scheduler/BUILD....
components/scheduler/BUILD.gn:78:
"renderer/renderer_scheduler_impl_unittest.cc",
ditto?

[rmcilroy, 2015-04-21 16:21:09]

A couple of comments but generally lgtm - thanks for doing the move! Please let
Sami have a look as well before committing though, thanks.

https://codereview.chromium.org/1058873010/diff/1/components/scheduler/BUILD.gn
File components/scheduler/BUILD.gn (right):

https://codereview.chromium.org/1058873010/diff/1/components/scheduler/BUILD....
components/scheduler/BUILD.gn:43: "scheduler_export.h",
Can we share the file list between GN and gyp?

https://codereview.chromium.org/1058873010/diff/1/components/scheduler/BUILD....
components/scheduler/BUILD.gn:78:
"renderer/renderer_scheduler_impl_unittest.cc",
ditto?

[Sami, 2015-04-21 17:48:25]

lgtm. I think we owe you a $BEVERAGE.

[jam, 2015-04-21 23:25:40]

the code being moved seems to be in a halfway state, i.e. most of it is moved
except the few files that send (chrome) IPCs. what's the plan, is that code
going to switch to mojo ipc and then the remaining files will move as well? why
not move everything now to keep the code always together? (I just worry that
it's confusing having it be split across two places)

[jam, 2015-04-21 23:56:05]

On 2015/04/21 23:25:40, jam wrote:
> the code being moved seems to be in a halfway state, i.e. most of it is moved
> except the few files that send (chrome) IPCs. what's the plan, is that code
> going to switch to mojo ipc and then the remaining files will move as well?
why
> not move everything now to keep the code always together? (I just worry that
> it's confusing having it be split across two places)

(btw i defer to you guys, just wondering. my preference would be to move
everything together, since the current code doesn't work in html_viewer now
anyways)

[jochen (gone - plz use gerrit), 2015-04-22 11:03:18]

I moved the thread-impls as well, the resource dispatcher thing is too coupled
with content to be moved.

also shared the sources list between gn and gyp, and made the static builders
happy

[Sami, 2015-04-22 11:19:37]

skyostil@chromium.org changed reviewers:
+ jdduke@chromium.org

[Sami, 2015-04-22 11:20:12]

(+jdduke)

On 2015/04/22 11:03:18, jochen wrote:
> I moved the thread-impls as well, the resource dispatcher thing is too coupled
> with content to be moved.

Right, the resource dispatcher is somewhat separate from the main scheduler
since it deals with a different type of scheduling (outgoing requests instead of
tasks). Splitting it out now is not a problem because I think it'll eventually
end up growing to be a more fully featured resource scheduler.

[jam, 2015-04-22 14:32:46]

lgtm

https://codereview.chromium.org/1058873010/diff/40001/components/scheduler/re...
File components/scheduler/renderer/DEPS (right):

https://codereview.chromium.org/1058873010/diff/40001/components/scheduler/re...
components/scheduler/renderer/DEPS:14: "+content/test",
this is temporary right? can you add a todo and specify this bug?

[rmcilroy, 2015-04-22 14:50:36]

On 2015/04/22 14:32:46, jam wrote:
> lgtm
> 
>
https://codereview.chromium.org/1058873010/diff/40001/components/scheduler/re...
> File components/scheduler/renderer/DEPS (right):
> 
>
https://codereview.chromium.org/1058873010/diff/40001/components/scheduler/re...
> components/scheduler/renderer/DEPS:14: "+content/test",
> this is temporary right? can you add a todo and specify this bug?

One last thing - could you also update the 'scheduler' section of WATCHLISTS to
point to the new location?

Still lgtm, thanks.

[jochen (gone - plz use gerrit), 2015-04-22 15:01:38]

done & done

[jochen (gone - plz use gerrit), 2015-04-22 15:10:23]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-04-22 15:10:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, jam@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1058873010/#ps80001
(title: "updates")

[commit-bot: I haz the power, 2015-04-22 15:10:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058873010/80001

[commit-bot: I haz the power, 2015-04-22 17:08:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-22 17:09:06]

Patchset 5 (id:??) landed as
https://crrev.com/83c639f0493539896ac7c2e8db0ac93898955599
Cr-Commit-Position: refs/heads/master@{#326320}