Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 1058873010: Move blink scheduler implementation into a component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/content/renderer/scheduler/renderer_scheduler_impl.cc b/components/scheduler/renderer/renderer_scheduler_impl.cc
similarity index 96%
rename from content/renderer/scheduler/renderer_scheduler_impl.cc
rename to components/scheduler/renderer/renderer_scheduler_impl.cc
index 7ca3eb7a7290131ac0b576c71597e6c402830886..5ed3d6d12d91062b9579ad61cefc601a04eec780 100644
--- a/content/renderer/scheduler/renderer_scheduler_impl.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl.cc
@@ -2,18 +2,18 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/renderer/scheduler/renderer_scheduler_impl.h"
+#include "components/scheduler/renderer/renderer_scheduler_impl.h"
#include "base/bind.h"
#include "base/message_loop/message_loop_proxy.h"
#include "base/trace_event/trace_event.h"
#include "base/trace_event/trace_event_argument.h"
#include "cc/output/begin_frame_args.h"
-#include "content/child/scheduler/nestable_single_thread_task_runner.h"
-#include "content/child/scheduler/prioritizing_task_queue_selector.h"
+#include "components/scheduler/child/nestable_single_thread_task_runner.h"
+#include "components/scheduler/child/prioritizing_task_queue_selector.h"
#include "ui/gfx/frame_time.h"
-namespace content {
+namespace scheduler {
RendererSchedulerImpl::RendererSchedulerImpl(
scoped_refptr<NestableSingleThreadTaskRunner> main_task_runner)
@@ -45,8 +45,7 @@ RendererSchedulerImpl::RendererSchedulerImpl(
end_renderer_hidden_idle_period_closure_.Reset(base::Bind(
&RendererSchedulerImpl::EndIdlePeriod, weak_factory_.GetWeakPtr()));
- for (size_t i = SchedulerHelper::TASK_QUEUE_COUNT;
- i < TASK_QUEUE_COUNT;
+ for (size_t i = SchedulerHelper::TASK_QUEUE_COUNT; i < TASK_QUEUE_COUNT;
i++) {
helper_.SetQueueName(i, TaskQueueIdToString(static_cast<QueueId>(i)));
}
@@ -133,10 +132,8 @@ void RendererSchedulerImpl::DidCommitFrameToCompositor() {
// TODO(rmcilroy): Consider reducing the idle period based on the runtime of
// the next pending delayed tasks (as currently done in for long idle times)
helper_.StartIdlePeriod(
- SchedulerHelper::IdlePeriodState::IN_SHORT_IDLE_PERIOD,
- now,
- estimated_next_frame_begin_,
- true);
+ SchedulerHelper::IdlePeriodState::IN_SHORT_IDLE_PERIOD, now,
+ estimated_next_frame_begin_, true);
}
}
@@ -168,8 +165,7 @@ void RendererSchedulerImpl::OnRendererHidden() {
base::TimeDelta end_idle_when_hidden_delay =
base::TimeDelta::FromMilliseconds(kEndIdleWhenHiddenDelayMillis);
control_task_runner_->PostDelayedTask(
- FROM_HERE,
- end_renderer_hidden_idle_period_closure_.callback(),
+ FROM_HERE, end_renderer_hidden_idle_period_closure_.callback(),
end_idle_when_hidden_delay);
renderer_hidden_ = true;
@@ -303,8 +299,8 @@ bool RendererSchedulerImpl::ShouldYieldForHighPriorityWork() {
}
}
-base::TimeTicks
-RendererSchedulerImpl::CurrentIdleTaskDeadlineForTesting() const {
+base::TimeTicks RendererSchedulerImpl::CurrentIdleTaskDeadlineForTesting()
+ const {
base::TimeTicks deadline;
helper_.CurrentIdleTaskDeadlineCallback(&deadline);
return deadline;
@@ -489,10 +485,6 @@ SchedulerHelper* RendererSchedulerImpl::GetSchedulerHelperForTesting() {
return &helper_;
}
-void RendererSchedulerImpl::SetWorkBatchSizeForTesting(size_t work_batch_size) {
- helper_.SetWorkBatchSizeForTesting(work_batch_size);
-}
-
RendererSchedulerImpl::PollableNeedsUpdateFlag::PollableNeedsUpdateFlag(
base::Lock* write_lock_)
: flag_(false), write_lock_(write_lock_) {
@@ -515,8 +507,8 @@ void RendererSchedulerImpl::SuspendTimerQueue() {
helper_.CheckOnValidThread();
timer_queue_suspend_count_++;
ForceUpdatePolicy();
- DCHECK(!helper_.SchedulerTaskQueueSelector()->IsQueueEnabled(
- TIMER_TASK_QUEUE));
+ DCHECK(
+ !helper_.SchedulerTaskQueueSelector()->IsQueueEnabled(TIMER_TASK_QUEUE));
}
void RendererSchedulerImpl::ResumeTimerQueue() {
@@ -638,4 +630,4 @@ RendererSchedulerImpl::ComputeNewInputStreamState(
return InputStreamState::ACTIVE;
}
-} // namespace content
+} // namespace scheduler

Powered by Google App Engine
This is Rietveld 408576698