Revert of Add button to add new FSP services to Files app.

ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 ////////////////////////////////////////////////////////////////////////////////
 // DirectoryTreeBase
 
 /**
  * Implementation of methods for DirectoryTree and DirectoryItem. These classes
  * inherits cr.ui.Tree/TreeItem so we can't make them inherit this class.
@@ skipping 329 matching lines @@
  * @constructor
  */
 function SubDirectoryItem(label, dirEntry, parentDirItem, tree) {
   var item = new DirectoryItem(label, tree);
   item.__proto__ = SubDirectoryItem.prototype;
 
   item.dirEntry_ = dirEntry;
 
   // Sets up icons of the item.
   var icon = item.querySelector('.icon');
-  icon.classList.add('item-icon');
+  icon.classList.add('volume-icon');
   var location = tree.volumeManager.getLocationInfo(item.entry);
   if (location && location.rootType && location.isRootEntry) {
     icon.setAttribute('volume-type-icon', location.rootType);
   } else {
     icon.setAttribute('file-type-icon', 'folder');
     item.updateSharedStatusIcon();
   }
 
   // Sets up context menu of the item.
   if (tree.contextMenuForSubitems)
@@ skipping 137 matching lines @@
          volumeType === VolumeManagerCommon.VolumeType.PROVIDED;
 };
 
 /**
  * Set up icon of this volume item.
  * @param {Element} icon Icon element to be setup.
  * @param {VolumeInfo} volumeInfo VolumeInfo determines the icon type.
  * @private
  */
 VolumeItem.prototype.setupIcon_ = function(icon, volumeInfo) {
-  icon.classList.add('item-icon');
+  icon.classList.add('volume-icon');
   if (volumeInfo.volumeType === VolumeManagerCommon.VolumeType.PROVIDED) {
     var backgroundImage = '-webkit-image-set(' +
         'url(chrome://extension-icon/' + volumeInfo.extensionId +
             '/16/1) 1x, ' +
         'url(chrome://extension-icon/' + volumeInfo.extensionId +
             '/32/1) 2x);';
     // The icon div is not yet added to DOM, therefore it is impossible to
     // use style.backgroundImage.
     icon.setAttribute(
         'style', 'background-image: ' + backgroundImage);
@@ skipping 163 matching lines @@
   var item = new cr.ui.TreeItem();
   item.__proto__ = ShortcutItem.prototype;
 
   item.parentTree_ = tree;
   item.dirEntry_ = modelItem.entry;
   item.modelItem_ = modelItem;
 
   item.innerHTML = TREE_ITEM_INNTER_HTML;
 
   var icon = item.querySelector('.icon');
-  icon.classList.add('item-icon');
+  icon.classList.add('volume-icon');
   icon.setAttribute('volume-type-icon', VolumeManagerCommon.VolumeType.DRIVE);
 
   if (tree.contextMenuForRootItems)
     item.setContextMenu(tree.contextMenuForRootItems);
 
   item.label = modelItem.entry.name;
   return item;
 }
 
 ShortcutItem.prototype = {
@@ skipping 72 matching lines @@
       onEntryResolved,
       function() {
         // Error, the entry can't be re-resolved. It may happen for shortcuts
         // which targets got removed after resolving the Entry during
         // initialization.
         this.parentTree_.dataModel.onItemNotFoundError(this.modelItem);
       }.bind(this));
 };
 
 ////////////////////////////////////////////////////////////////////////////////
-// CommandItem
-
-/**
- * A TreeItem which represents a command button.
- * Command items are displayed as top-level children of DirectoryTree.
- *
- * @param {NavigationModelCommandItem} modelItem
- * @param {DirectoryTree} tree Current tree, which contains this item.
- * @extends {cr.ui.TreeItem}
- * @constructor
- */
-function CommandItem(modelItem, tree) {
-  var item = new cr.ui.TreeItem();
-  item.__proto__ = CommandItem.prototype;
-
-  item.parentTree_ = tree;
-  item.modelItem_ = modelItem;
-
-  item.innerHTML = TREE_ITEM_INNTER_HTML;
-
-  var icon = item.querySelector('.icon');
-  icon.classList.add('item-icon');
-  icon.setAttribute('command-icon', modelItem.command.id);
-
-  item.label = modelItem.label;
-  return item;
-}
-
-CommandItem.prototype = {
-  __proto__: cr.ui.TreeItem.prototype,
-  get entry() {
-    return null;
-  },
-  get modelItem() {
-    return this.modelItem_;
-  },
-  get labelElement() {
-    return this.firstElementChild.querySelector('.label');
-  }
-};
-
-/**
- * @param {!DirectoryEntry|!FakeEntry} entry
- * @return {boolean} True if the parent item is found.
- */
-CommandItem.prototype.searchAndSelectByEntry = function(entry) {
-  return false;
-};
-
-/**
- * @override
- */
-CommandItem.prototype.handleClick = function(e) {
-  this.activate();
-};
-
-/**
- * @param {!DirectoryEntry} entry
- */
-CommandItem.prototype.selectByEntry = function(entry) {
-};
-
-/**
- * Executes the command.
- */
-CommandItem.prototype.activate = function() {
-  this.modelItem_.command.execute();
-};
-
-
-////////////////////////////////////////////////////////////////////////////////
 // DirectoryTree
 
 /**
  * Tree of directories on the middle bar. This element is also the root of
  * items, in other words, this is the parent of the top-level items.
  *
  * @constructor
  * @extends {cr.ui.Tree}
  */
 function DirectoryTree() {}
@@ skipping 85 matching lines @@
  * @param {boolean} recursive True if the all visible sub-directories are
  *     updated recursively including left arrows. If false, the update walks
  *     only immediate child directories without arrows.
  */
 DirectoryTree.prototype.updateSubElementsFromList = function(recursive) {
   // First, current items which is not included in the dataModel should be
   // removed.
   for (var i = 0; i < this.items.length;) {
     var found = false;
     for (var j = 0; j < this.dataModel.length; j++) {
-      // Comparison by references, which is safe here, as model items are long
-      // living.
-      if (this.items[i].modelItem === this.dataModel.item(j)) {
+      if (NavigationModelItem.isSame(this.items[i].modelItem,
+                                     this.dataModel.item(j))) {
         found = true;
         break;
       }
     }
     if (!found) {
       if (this.items[i].selected)
         this.items[i].selected = false;
       this.remove(this.items[i]);
     } else {
       i++;
     }
   }
 
   // Next, insert items which is in dataModel but not in current items.
   var modelIndex = 0;
   var itemIndex = 0;
   while (modelIndex < this.dataModel.length) {
     if (itemIndex < this.items.length &&
-        this.items[itemIndex].modelItem === this.dataModel.item(modelIndex)) {
+        NavigationModelItem.isSame(this.items[itemIndex].modelItem,
+                                   this.dataModel.item(modelIndex))) {
       if (recursive && this.items[itemIndex] instanceof VolumeItem)
         this.items[itemIndex].updateSubDirectories(true);
     } else {
       var modelItem = this.dataModel.item(modelIndex);
-      switch (modelItem.type) {
-        case NavigationModelItem.Type.VOLUME:
-          if (modelItem.volumeInfo.volumeType ===
-              VolumeManagerCommon.VolumeType.DRIVE) {
-            this.addAt(new DriveVolumeItem(modelItem, this), itemIndex);
-          } else {
-            this.addAt(new VolumeItem(modelItem, this), itemIndex);
-          }
-          break;
-        case NavigationModelItem.Type.SHORTCUT:
-          this.addAt(new ShortcutItem(modelItem, this), itemIndex);
-          break;
-        case NavigationModelItem.Type.COMMAND:
-          this.addAt(new CommandItem(modelItem, this), itemIndex);
-          break;
+      if (modelItem.isVolume) {
+        if (modelItem.volumeInfo.volumeType ===
+            VolumeManagerCommon.VolumeType.DRIVE) {
+          this.addAt(new DriveVolumeItem(modelItem, this), itemIndex);
+        } else {
+          this.addAt(new VolumeItem(modelItem, this), itemIndex);
+        }
+      } else {
+        this.addAt(new ShortcutItem(modelItem, this), itemIndex);
       }
     }
     itemIndex++;
     modelIndex++;
   }
 
   if (itemIndex !== 0)
     this.hasChildren = true;
 };
 
@@ skipping 192 matching lines @@
     }
   }.bind(this));
 };
 
 /**
  * Updates the UI after the layout has changed.
  */
 DirectoryTree.prototype.relayout = function() {
   cr.dispatchSimpleEvent(this, 'relayout', true);
 };