Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 1058873004: Revert of Add button to add new FSP services to Files app. (Closed)

Created:
5 years, 8 months ago by mfomitchev
Modified:
5 years, 8 months ago
Reviewers:
mtomasz, hirono, Dan Beam
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add button to add new FSP services to Files app. (patchset #8 id:140001 of https://codereview.chromium.org/1056433003/) Reason for revert: Broke the build: http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/18940 ## /mnt/data/b/build/slave/Closure_Compilation_Linux/build/src/ui/file_manager/file_manager/foreground/js/navigation_list_model.js:33: ERROR - NavigationModelShortcutItem cannot extend this type; structs can only extend structs ## function NavigationModelShortcutItem(label, entry) { Original issue's description: > Add button to add new FSP services to Files app. > > This CL adds a FSP suggest dialog which can be shown by clicking the button at > the end of the left nav. > > TEST=Tested manually by clicking on the new button in the left nav. > BUG=471722 TBR=hirono@chromium.org,mtomasz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471722 Committed: https://crrev.com/698a1525a28f2875f171495f78012ab872e8e7a2 Cr-Commit-Position: refs/heads/master@{#323556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -248 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_types.css View 1 chunk +0 lines, -6 lines 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/2x/add.png View Binary file 0 comments Download
D ui/file_manager/file_manager/foreground/images/volumes/add.png View Binary file 0 comments Download
M ui/file_manager/file_manager/foreground/js/cws_container_client.js View 2 chunks +13 lines, -7 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 1 chunk +0 lines, -15 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/navigation_list_model.js View 7 chunks +39 lines, -46 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 6 chunks +16 lines, -93 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js View 9 chunks +27 lines, -54 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/copy_between_windows.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/integration_tests/file_manager/file_display.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/integration_tests/file_manager/folder_shortcuts.js View 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
mfomitchev
Created Revert of Add button to add new FSP services to Files app.
5 years, 8 months ago (2015-04-02 20:26:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058873004/1
5 years, 8 months ago (2015-04-02 20:30:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 20:38:13 UTC) #3
Dan Beam
for what it's worth: it's up to your team whether to revert on closure compilation ...
5 years, 8 months ago (2015-04-02 21:22:26 UTC) #5
mfomitchev
On 2015/04/02 21:22:26, Dan Beam wrote: > for what it's worth: it's up to your ...
5 years, 8 months ago (2015-04-02 21:59:53 UTC) #6
Dan Beam
On 2015/04/02 21:59:53, mfomitchev wrote: > On 2015/04/02 21:22:26, Dan Beam wrote: > > for ...
5 years, 8 months ago (2015-04-02 22:23:13 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:28:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/698a1525a28f2875f171495f78012ab872e8e7a2
Cr-Commit-Position: refs/heads/master@{#323556}

Powered by Google App Engine
This is Rietveld 408576698