Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 105883012: Make arguments to Element methods non-optional (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, arv+blink, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Make arguments to Element methods non-optional http://dom.spec.whatwg.org/#interface-element Only touch methods defined by the above spec. The added missing-arguments test passes in Firefox Nightly, and Opera 12.16. IE11 Release Preview passes all except getAttribute, removeAttribute and setAttribute, where it returns null/undefined instead of throwing. Taken together, this could break IE- and Chrome-only content. This re-lands https://codereview.chromium.org/98543009 after having landed https://codereview.chromium.org/111833002/ in Chromium. BUG=325922 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163705

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
philipj_slow
Already reviewed in https://codereview.chromium.org/98543009 Jochen, what's the standard procedure for re-landing patches? I've seen different ...
7 years ago (2013-12-11 09:28:03 UTC) #1
jochen (gone - plz use gerrit)
On 2013/12/11 09:28:03, philipj wrote: > Already reviewed in https://codereview.chromium.org/98543009 > > Jochen, what's the ...
7 years ago (2013-12-11 11:43:59 UTC) #2
philipj_slow
On 2013/12/11 11:43:59, jochen wrote: > On 2013/12/11 09:28:03, philipj wrote: > > Already reviewed ...
7 years ago (2013-12-11 12:05:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/105883012/1
7 years ago (2013-12-11 12:06:10 UTC) #4
commit-bot: I haz the power
Change committed as 163705
7 years ago (2013-12-11 13:34:58 UTC) #5
eseidel
7 years ago (2013-12-21 02:13:46 UTC) #6
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/120373003/ by eseidel@chromium.org.

The reason for reverting is: Broken twitter.  Reverting is easy, so doing that
first, can land a more surgical fix..

Powered by Google App Engine
This is Rietveld 408576698