Destruct all instances of value types in WTF::HashTable.

Destruct all instances of value types in WTF::HashTable.

HashTable creates empty values for all buckets, but does not destruct them.

BUG=none
TEST=HashMapTest.ValueTypeDestructor

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193102

[dgozman, 2015-04-02 15:04:27]

dgozman@chromium.org changed reviewers:
+ haraken@chromium.org, jochen@chromium.org

[dgozman, 2015-04-02 15:04:27]

Hi,

Could you please take a look?
I think this was regressed in https://codereview.chromium.org/216723002, which
changed |isDeletedBucket| call to |isEmptyOrDeletedBucket|.

Thanks,
Dmitry

[haraken, 2015-04-02 15:14:45]

haraken@chromium.org changed reviewers:
+ erikcorry@chromium.org

[haraken, 2015-04-02 15:14:46]

+Erik

[dgozman, 2015-04-02 16:32:35]

Looks like this conflicts with Heap stuff. On the other hand, when working with
value type InjectedScript (similar to the added test), I've got destructors
problem. See
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20T...

WDYT is the right behavior?

[dgozman, 2015-04-02 16:56:13]

On 2015/04/02 16:32:35, dgozman wrote:
> Looks like this conflicts with Heap stuff. On the other hand, when working
with
> value type InjectedScript (similar to the added test), I've got destructors
> problem. See
>
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20T...
> 
> WDYT is the right behavior?

I think patchset 2 fixes the heap issue, but it's still surprising to me that we
should behave differently for heap/non-heap cases.

[dgozman, 2015-04-03 08:37:37]

Friendly ping.

[pfeldman, 2015-04-03 09:47:22]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-04-03 09:47:22]

lgtm

[haraken, 2015-04-03 09:58:16]

LGTM

[dgozman, 2015-04-03 10:00:54]

dgozman@chromium.org changed reviewers:
+ tkent@chromium.org

[dgozman, 2015-04-03 10:00:55]

+tkent@ for OWNER review

[tkent, 2015-04-03 10:09:08]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-04-03 10:09:09]

lgtm

[commit-bot: I haz the power, 2015-04-03 10:09:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058653004/20001

[commit-bot: I haz the power, 2015-04-03 10:29:52]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193102