Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: Source/wtf/HashMapTest.cpp

Issue 1058653004: Destruct all instances of value types in WTF::HashTable. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed heap case Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/wtf/HashTable.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 EXPECT_EQ(11, map.find(1)->value.first()); 277 EXPECT_EQ(11, map.find(1)->value.first());
278 278
279 IntVectorMap::AddResult result2 = map.add(1, Vector<int>()); 279 IntVectorMap::AddResult result2 = map.add(1, Vector<int>());
280 EXPECT_FALSE(result2.isNewEntry); 280 EXPECT_FALSE(result2.isNewEntry);
281 EXPECT_EQ(1, result.storedValue->key); 281 EXPECT_EQ(1, result.storedValue->key);
282 EXPECT_EQ(1u, result.storedValue->value.size()); 282 EXPECT_EQ(1u, result.storedValue->value.size());
283 EXPECT_EQ(11, result.storedValue->value.first()); 283 EXPECT_EQ(11, result.storedValue->value.first());
284 EXPECT_EQ(11, map.find(1)->value.first()); 284 EXPECT_EQ(11, map.find(1)->value.first());
285 } 285 }
286 286
287 class InstanceCounter {
288 public:
289 InstanceCounter() { ++counter; }
290 InstanceCounter(const InstanceCounter& another) { ++counter; }
291 ~InstanceCounter() { --counter; }
292 static int counter;
293 };
294 int InstanceCounter::counter = 0;
295
296 TEST(HashMapTest, ValueTypeDestructed)
297 {
298 InstanceCounter::counter = 0;
299 HashMap<int, InstanceCounter> map;
300 map.set(1, InstanceCounter());
301 map.clear();
302 EXPECT_EQ(0, InstanceCounter::counter);
303 }
304
287 } // namespace 305 } // namespace
OLDNEW
« no previous file with comments | « no previous file | Source/wtf/HashTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698