src/mips/lithium-codegen-mips.cc - Issue 1058533007: Fix a few potential integer negation overflows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/lithium-codegen-mips.cc

Issue 1058533007: Fix a few potential integer negation overflows (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/lithium-codegen-mips.cc

diff --git a/src/mips/lithium-codegen-mips.cc b/src/mips/lithium-codegen-mips.cc

index 6431100e5ff2303cca7dedea66389838e373e370..612de1b7ecb1519e0d96d84266097c88df2f5869 100644

--- a/src/mips/lithium-codegen-mips.cc

+++ b/src/mips/lithium-codegen-mips.cc

@@ -3141,7 +3141,6 @@ void LCodeGen::DoLoadKeyedExternalArray(LLoadKeyed* instr) {

elements_kind == FLOAT32_ELEMENTS ||

elements_kind == EXTERNAL_FLOAT64_ELEMENTS ||

elements_kind == FLOAT64_ELEMENTS) {

- int base_offset = instr->base_offset();

FPURegister result = ToDoubleRegister(instr->result());

if (key_is_constant) {

__ Addu(scratch0(), external_pointer, constant_key << element_size_shift);