src/hydrogen-instructions.cc - Issue 1058533007: Fix a few potential integer negation overflows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 1058533007: Fix a few potential integer negation overflows (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index a3436ed94d771602947fade2df9eacdca9237e82..66255f28eaf1d5406b57aa22a11472e7434227f6 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -2230,7 +2230,9 @@ int32_t InductionVariableData::ComputeIncrement(HPhi* phi,

HSub* operation = HSub::cast(phi_operand);

if (operation->left() == phi &&

operation->right()->IsInteger32Constant()) {

- return -operation->right()->GetInteger32Constant();

+ int constant = operation->right()->GetInteger32Constant();

+ if (constant == kMinInt) return 0;

+ return -constant;

}