Bookmarked URL gets open in New tab, on pressing enter key for 'Folders' dropdown.

Bookmarked URL gets open in New tab, on pressing enter key for 'Folders' dropdown.

When we select enter key then open item is getting called and it opens last focused item.
This is due to 2 reasons:
1) getSelectedBookmarkNodes() returns bmm.list.selectedItems even when document.activeElement
is 'Folders' or 'Organize' button.
2) openItem() is for opening the item in the list, for that bmm.list should be currently active

Check have been added so that when we have bmm.list is active then only e.canExecute will become true.

BUG=452853
Committed: https://crrev.com/4a6bfb77e3e806a58b6bdd89825f1d4a058df4d5
Cr-Commit-Position: refs/heads/master@{#325426}

[Deepak, 2015-04-16 07:01:54]

deepak.m1@samsung.com changed reviewers:
+ bauerb@chromium.org

[Deepak, 2015-04-16 07:01:54]

PTAL.

[Bernhard Bauer, 2015-04-16 09:01:19]

https://codereview.chromium.org/1058533006/diff/40001/chrome/browser/resource...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

https://codereview.chromium.org/1058533006/diff/40001/chrome/browser/resource...
chrome/browser/resources/bookmark_manager/js/main.js:511: e.canExecute =
e.currentTarget.activeElement == bmm.list;
There is also a second check below in canExecuteForList, which we would never
reach if we set canExecute to true here. I think we could just move this down
and combine the checks?

[Deepak, 2015-04-16 09:41:47]

On 2015/04/16 09:01:19, Bernhard Bauer wrote:
>
https://codereview.chromium.org/1058533006/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/bookmark_manager/js/main.js (right):
> 
>
https://codereview.chromium.org/1058533006/diff/40001/chrome/browser/resource...
> chrome/browser/resources/bookmark_manager/js/main.js:511: e.canExecute =
> e.currentTarget.activeElement == bmm.list;
> There is also a second check below in canExecuteForList, which we would never
> reach if we set canExecute to true here. I think we could just move this down
> and combine the checks?

Thanks for review and suggestion.
Changes done as suggested.
PTAL

[Bernhard Bauer, 2015-04-16 09:45:14]

https://codereview.chromium.org/1058533006/diff/60001/chrome/browser/resource...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

https://codereview.chromium.org/1058533006/diff/60001/chrome/browser/resource...
chrome/browser/resources/bookmark_manager/js/main.js:638: e.canExecute =
e.target == bmm.list ? hasSelected() : false;
Use a logical-and operator instead.

[Deepak, 2015-04-16 10:03:20]

Changes done.
PTAL
Thanks

https://codereview.chromium.org/1058533006/diff/60001/chrome/browser/resource...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

https://codereview.chromium.org/1058533006/diff/60001/chrome/browser/resource...
chrome/browser/resources/bookmark_manager/js/main.js:638: e.canExecute =
e.target == bmm.list ? hasSelected() : false;
On 2015/04/16 09:45:14, Bernhard Bauer wrote:
> Use a logical-and operator instead.

Done.

[Bernhard Bauer, 2015-04-16 11:05:33]

LGTM

[Deepak, 2015-04-16 11:06:03]

On 2015/04/16 11:05:33, Bernhard Bauer wrote:
> LGTM

Thanks

[Deepak, 2015-04-16 11:06:07]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-04-16 11:06:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058533006/80001

[commit-bot: I haz the power, 2015-04-16 12:22:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-04-16 12:23:46]

Patchset 5 (id:??) landed as
https://crrev.com/4a6bfb77e3e806a58b6bdd89825f1d4a058df4d5
Cr-Commit-Position: refs/heads/master@{#325426}