chrome/browser/resources/bookmark_manager/js/main.js - Issue 1058533006: Bookmarked URL gets open in New tab, on pressing enter key for 'Folders' dropdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/bookmark_manager/js/main.js

Issue 1058533006: Bookmarked URL gets open in New tab, on pressing enter key for 'Folders' dropdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/bookmark_manager/js/main.js

diff --git a/chrome/browser/resources/bookmark_manager/js/main.js b/chrome/browser/resources/bookmark_manager/js/main.js

index 5bd11d1878021c2203668ef36e614a818529cd76..87680e60bef3e1caa95ce5a7c3ea3a4ea0737dff 100644

--- a/chrome/browser/resources/bookmark_manager/js/main.js

+++ b/chrome/browser/resources/bookmark_manager/js/main.js

@@ -635,7 +635,7 @@ function canExecuteForList(e) {

break;

case 'open-in-same-window-command':

- e.canExecute = hasSelected();

+ e.canExecute = (e.target == bmm.list) && hasSelected();

break;

default:

« no previous file with comments | « no previous file | no next file » | no next file with comments »