Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1058533003: Update descendent layer positions when a DeprecatedPaintLayer is removed. (Closed)

Created:
5 years, 8 months ago by skobes
Modified:
5 years, 8 months ago
Reviewers:
dstockwell
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr+renderingwatchlist_chromium.org, rjwright, shans, Steve Block, Timothy Loh, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update descendent layer positions when a DeprecatedPaintLayer is removed. This parallels what we already do when a layer is created. The bug triggers upon completion of an animation on an element that had no other reason to have a DeprecatedPaintLayer (inline, statically positioned). Between http://crrev.com/445263002 and http://crrev.com/786933002 it happened to work correctly, because we were recomputing the layer position on demand. BUG=464505 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193089

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
A LayoutTests/animations/inline-element-animation-end-hit-test.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/animations/inline-element-animation-end-hit-test-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBoxModelObject.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
skobes
5 years, 8 months ago (2015-04-02 02:33:28 UTC) #2
dstockwell
lgtm, thanks!
5 years, 8 months ago (2015-04-02 03:02:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058533003/1
5 years, 8 months ago (2015-04-02 03:58:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/30337)
5 years, 8 months ago (2015-04-02 04:08:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058533003/20001
5 years, 8 months ago (2015-04-02 17:10:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/31582)
5 years, 8 months ago (2015-04-02 17:32:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058533003/20001
5 years, 8 months ago (2015-04-02 17:35:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/31530)
5 years, 8 months ago (2015-04-02 17:44:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058533003/20001
5 years, 8 months ago (2015-04-02 17:45:30 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/31532)
5 years, 8 months ago (2015-04-02 17:59:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058533003/20001
5 years, 8 months ago (2015-04-02 20:06:42 UTC) #22
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 05:56:56 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193089

Powered by Google App Engine
This is Rietveld 408576698