Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1058163002: Replaces |shell_handle| with |application_request| as the name of the parameter to MojoMain(). (Closed)

Created:
5 years, 8 months ago by rudominer
Modified:
5 years, 8 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Replaces |shell_handle| with |application_request| as the name of the parameter to MojoMain(). BUG=468496 R=viettrungluu@chromium.org, viettrungluu Committed: https://chromium.googlesource.com/external/mojo/+/963aa773ade0b13853ca563a57a9d676f980f9af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -114 lines) Patch
M benchmarks/startup/startup.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/apptest/example_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/browser/browser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/content_handler_demo/content_handler_demo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/device_name/device_name.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/echo/echo_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/echo/echo_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/echo_terminal/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/embedded_app/embedded_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/forwarding_content_handler/forwarding_content_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/ganesh_app/ganesh_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/http_handler/http_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/indirect_service/indirect_integer_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/indirect_service/indirect_service_demo.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/indirect_service/integer_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/nesting_app/nesting_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/pdf_viewer/pdf_viewer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/png_viewer/png_viewer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/recursive_content_handler/recursive_content_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/spinning_cube/spinning_cube_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_gl_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/surfaces_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/versioning/hr_system_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/versioning/hr_system_server.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wget/wget.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/window_manager/window_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wm_flow/app/app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wm_flow/embedded/embedded.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wm_flow/wm/wm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/application/application_runner_chromium.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/application/application_runner.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/tools/package_manager/package_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/android/java_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/clipboard/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/console/console.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/dart/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/fake_surfaces/fake_surfaces_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/files/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/http_server/http_server_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/icu_data/icu_data_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/js/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/kiosk_wm/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/nacl/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_viewport/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/python/content_handler/content_handler_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/reaper/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/surfaces/surfaces_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/test_service/test_request_tracker_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/test_service/test_service_application.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/window_manager/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M shell/test/pingable_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tools/tester/tester.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/viewer/viewer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rudominer
These are the commands I ran: find . -type f -name "*cc" -exec sed -i ...
5 years, 8 months ago (2015-04-02 22:38:43 UTC) #2
viettrungluu
lgtm
5 years, 8 months ago (2015-04-03 02:06:19 UTC) #3
rudominer
5 years, 8 months ago (2015-04-03 15:23:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
963aa773ade0b13853ca563a57a9d676f980f9af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698