Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/android/system/core_impl.cc

Issue 1058143002: Fix Android for positive MojoResults. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: oops Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java » ('j') | mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/android/system/core_impl.cc
diff --git a/mojo/android/system/core_impl.cc b/mojo/android/system/core_impl.cc
index 55a374e50bcba68e1bff0ef41548c9278b2052a6..576346deeb0a4c0923c39d5b417c1f8b6ce503f1 100644
--- a/mojo/android/system/core_impl.cc
+++ b/mojo/android/system/core_impl.cc
@@ -238,7 +238,7 @@ static jint ReadData(JNIEnv* env,
}
MojoResult result =
MojoReadData(mojo_handle, buffer_start, &buffer_size, flags);
- if (result < 0) {
+ if (result != MOJO_RESULT_OK) {
return result;
}
return buffer_size;
viettrungluu 2015/04/02 23:02:42 This is very wrong.
@@ -281,7 +281,7 @@ static jint WriteData(JNIEnv* env,
uint32_t buffer_size = limit;
MojoResult result =
MojoWriteData(mojo_handle, buffer_start, &buffer_size, flags);
- if (result < 0) {
+ if (result != MOJO_RESULT_OK) {
return result;
}
return buffer_size;
viettrungluu 2015/04/02 23:02:42 "
« no previous file with comments | « no previous file | mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java » ('j') | mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698