Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Issue 1058133003: Add GM to exercise high quality anisotropic scaling (Closed)

Created:
5 years, 8 months ago by robertphillips
Modified:
5 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add GM to exercise high quality anisotropic scaling High quality anisotropic is an interesting edge case for the gpu backend. For scales that are both minimizing and maximizing Ganesh falls back to MipMaps which can turn out too blurry. BUG=472864 Committed: https://skia.googlesource.com/skia/+/f5ac972207228e288ff084ff4a94dd7f89c4ba72

Patch Set 1 #

Patch Set 2 : SK_ARRAY_COUNT should return an int #

Patch Set 3 : ditto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -0 lines) Patch
A gm/anisotropic.cpp View 1 2 1 chunk +114 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
robertphillips
5 years, 8 months ago (2015-04-14 13:47:56 UTC) #2
bsalomon
lgtm
5 years, 8 months ago (2015-04-14 14:46:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058133003/1
5 years, 8 months ago (2015-04-14 14:55:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/478)
5 years, 8 months ago (2015-04-14 14:58:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058133003/20001
5 years, 8 months ago (2015-04-14 15:08:15 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/456) Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 8 months ago (2015-04-14 15:09:26 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058133003/40001
5 years, 8 months ago (2015-04-14 15:10:55 UTC) #15
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-14 15:16:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058133003/40001
5 years, 8 months ago (2015-04-14 15:18:55 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 15:19:05 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f5ac972207228e288ff084ff4a94dd7f89c4ba72

Powered by Google App Engine
This is Rietveld 408576698