Issue 10581014: BoundsCheck should be extended to support array_bounds_checks_elimination

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10581014: BoundsCheck should be extended to support array_bounds_checks_elimination (Closed)

Created:
8 years, 6 months ago by Zheng Liu

Modified:
8 years ago

Reviewers:
fschneider, Massi

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

BoundsCheck should be extended to support --array_bounds_checks_elimination TEST=mjsunit/array-bounds-check-removal.js BoundsCheck LIR implementation supposes op2=length belong to [0,int32_max], so "sub length, upper_offset" is not correct. Moved lower/upper offset handling to LIR because I feel it is simpler. Only fixed x86/x64 port. array_bounds_checks_elimination remains disabled, because I have no permission to check bug in http://code.google.com/p/v8/source/detail?r=11775 Zheng Liu zheng.z.liu@intel.com

Patch Set 1 : #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -89 lines)			Patch
M	src/arm/lithium-arm.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+5 lines, -57 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+26 lines, -4 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+49 lines, -16 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+10 lines, -3 lines	0 comments	Download
M	test/mjsunit/array-bounds-check-removal.js	View	2 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Zheng Liu

8 years, 6 months ago (2012-06-19 10:25:11 UTC) #1

Also array_bounds_checks_elimination now seems to slight gain in kraken in my
measurement (Nehalem 2.8G, both ia32 and x64). As desaturate doesn't regress and
guassian-blur remains a little faster.

Zheng Liu
zheng.z.liu@intel.com

Expand Messages | Collapse Messages