Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 10581014: BoundsCheck should be extended to support array_bounds_checks_elimination (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/array-bounds-check-removal.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1583 matching lines...) Expand 10 before | Expand all | Expand 10 after
1594 1594
1595 1595
1596 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) { 1596 LInstruction* LChunkBuilder::DoDateField(HDateField* instr) {
1597 LOperand* object = UseFixed(instr->value(), rax); 1597 LOperand* object = UseFixed(instr->value(), rax);
1598 LDateField* result = new(zone()) LDateField(object, instr->index()); 1598 LDateField* result = new(zone()) LDateField(object, instr->index());
1599 return MarkAsCall(DefineFixed(result, rax), instr); 1599 return MarkAsCall(DefineFixed(result, rax), instr);
1600 } 1600 }
1601 1601
1602 1602
1603 LInstruction* LChunkBuilder::DoBoundsCheck(HBoundsCheck* instr) { 1603 LInstruction* LChunkBuilder::DoBoundsCheck(HBoundsCheck* instr) {
1604 LOperand* value = UseRegisterOrConstantAtStart(instr->index()); 1604 if (instr->index()->IsConstant() ||
1605 LOperand* length = Use(instr->length()); 1605 (instr->lower_offset() == 0 && instr->upper_offset() == 0)) {
1606 return AssignEnvironment(new(zone()) LBoundsCheck(value, length)); 1606 return AssignEnvironment(new(zone()) LBoundsCheck(
1607 UseRegisterOrConstantAtStart(instr->index()),
1608 Use(instr->length()), NULL));
1609 } else {
1610 return AssignEnvironment(new(zone()) LBoundsCheck(
1611 UseRegisterOrConstant(instr->index()),
1612 Use(instr->length()), TempRegister()));
1613 }
1607 } 1614 }
1608 1615
1609 1616
1610 LInstruction* LChunkBuilder::DoAbnormalExit(HAbnormalExit* instr) { 1617 LInstruction* LChunkBuilder::DoAbnormalExit(HAbnormalExit* instr) {
1611 // The control instruction marking the end of a block that completed 1618 // The control instruction marking the end of a block that completed
1612 // abruptly (e.g., threw an exception). There is nothing specific to do. 1619 // abruptly (e.g., threw an exception). There is nothing specific to do.
1613 return NULL; 1620 return NULL;
1614 } 1621 }
1615 1622
1616 1623
(...skipping 709 matching lines...) Expand 10 before | Expand all | Expand 10 after
2326 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2333 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2327 LOperand* object = UseRegister(instr->object()); 2334 LOperand* object = UseRegister(instr->object());
2328 LOperand* index = UseTempRegister(instr->index()); 2335 LOperand* index = UseTempRegister(instr->index());
2329 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2336 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2330 } 2337 }
2331 2338
2332 2339
2333 } } // namespace v8::internal 2340 } } // namespace v8::internal
2334 2341
2335 #endif // V8_TARGET_ARCH_X64 2342 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-x64.h ('k') | test/mjsunit/array-bounds-check-removal.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698