third_party/mojo/src/mojo/public/tools/gn/zip.py - Issue 1058033002: NOT TO COMMITTED: Update mojo sdk to rev 0018e6a91b75bcb941c867f8a7aa1753c3b53a13

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/gn/zip.py

Issue 1058033002: NOT TO COMMITTED: Update mojo sdk to rev 0018e6a91b75bcb941c867f8a7aa1753c3b53a13 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/dart_analyze.py ('k') | third_party/mojo/src/mojo/public/tools/mojom_fetcher/mojom_fetcher.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/gn/zip.py

diff --git a/third_party/mojo/src/mojo/public/tools/gn/zip.py b/third_party/mojo/src/mojo/public/tools/gn/zip.py

index 506eb9ea2a4203cb8fa14535413e7b559aa53a2a..a73f801d04ce818abd4afb1fae5a8151a9a82853 100755

--- a/third_party/mojo/src/mojo/public/tools/gn/zip.py

+++ b/third_party/mojo/src/mojo/public/tools/gn/zip.py

@@ -15,7 +15,7 @@ import zipfile

def DoZip(inputs, zip_inputs, output, base_dir):

files = []

- with zipfile.ZipFile(output, 'w') as outfile:

+ with zipfile.ZipFile(output, 'w', zipfile.ZIP_DEFLATED) as outfile:

for f in inputs:

file_name = os.path.relpath(f, base_dir)

files.append(file_name)