third_party/mojo/src/mojo/public/tools/dart_analyze.py - Issue 1058033002: NOT TO COMMITTED: Update mojo sdk to rev 0018e6a91b75bcb941c867f8a7aa1753c3b53a13

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/dart_analyze.py

Issue 1058033002: NOT TO COMMITTED: Update mojo sdk to rev 0018e6a91b75bcb941c867f8a7aa1753c3b53a13 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/pack.py ('k') | third_party/mojo/src/mojo/public/tools/gn/zip.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/dart_analyze.py

diff --git a/third_party/mojo/src/mojo/public/tools/dart_analyze.py b/third_party/mojo/src/mojo/public/tools/dart_analyze.py

index c200783adcdebb20ce8f6c80518185ab841b9c75..f26ddbf3780ed5ee1c0373ea5c6ad5c71fd213fd 100755

--- a/third_party/mojo/src/mojo/public/tools/dart_analyze.py

+++ b/third_party/mojo/src/mojo/public/tools/dart_analyze.py

@@ -20,6 +20,9 @@ import tempfile

import zipfile

_ANALYZING_PATTERN = re.compile(r'^Analyzing \[')

+_NO_ISSUES_FOUND_PATTERN = re.compile(r'^No issues found')

+_PART_WARNINGS_PATTERN = re.compile(

+ r'.*is a part and can not|^Only libraries can be analyzed')

_ERRORS_AND_WARNINGS_PATTERN = re.compile(

r'^[0-9]+ errors? and [0-9]+ warnings? found.')

_ERRORS_PATTERN = re.compile(r'^([0-9]+|No) (error|warning|issue)s? found.')

@@ -59,6 +62,8 @@ def main(args):

raw_lines.pop()

filtered_lines = [i for i in raw_lines if (

not re.match(_ANALYZING_PATTERN, i) and

+ not re.match(_NO_ISSUES_FOUND_PATTERN, i) and

+ not re.match(_PART_WARNINGS_PATTERN, i) and

not re.match(_ERRORS_AND_WARNINGS_PATTERN, i) and

not re.match(_ERRORS_PATTERN, i))]

for line in filtered_lines: