Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1058013005: [Telemetry] Switch BeginGestureInteraction to CreateGestureInteraction. (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Switch BeginGestureInteraction to CreateGestureInteraction. top_25_smooth (https://codereview.chromium.org/1052493004) top_7_stress (https://codereview.chromium.org/1082363003) tough_pinch_zoom_cases(https://codereview.chromium.org/1088003002) (the links are trybot links of benchmarks that use the page set) BUG=475090 Committed: https://crrev.com/f69146523e37356282404a95b14254967b103387 Cr-Commit-Position: refs/heads/master@{#325248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -101 lines) Patch
M tools/perf/page_sets/top_25_smooth.py View 5 chunks +11 lines, -21 lines 0 comments Download
M tools/perf/page_sets/top_7_stress.py View 5 chunks +32 lines, -64 lines 0 comments Download
M tools/perf/page_sets/tough_pinch_zoom_cases.py View 4 chunks +9 lines, -16 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
nednguyen
5 years, 8 months ago (2015-04-14 22:58:49 UTC) #2
eakuefner
lgtm
5 years, 8 months ago (2015-04-14 23:05:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058013005/1
5 years, 8 months ago (2015-04-14 23:05:12 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-14 23:05:14 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058013005/1
5 years, 8 months ago (2015-04-14 23:06:12 UTC) #9
nednguyen
On 2015/04/14 23:06:12, I haz the power (commit-bot) wrote: > Dry run: CQ is trying ...
5 years, 8 months ago (2015-04-14 23:07:56 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/61492)
5 years, 8 months ago (2015-04-14 23:26:57 UTC) #12
sullivan
lgtm
5 years, 8 months ago (2015-04-15 15:28:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058013005/1
5 years, 8 months ago (2015-04-15 15:28:54 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 15:38:19 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 15:39:12 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f69146523e37356282404a95b14254967b103387
Cr-Commit-Position: refs/heads/master@{#325248}

Powered by Google App Engine
This is Rietveld 408576698