Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: tools/perf/page_sets/tough_pinch_zoom_cases.py

Issue 1058013005: [Telemetry] Switch BeginGestureInteraction to CreateGestureInteraction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/top_7_stress.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/tough_pinch_zoom_cases.py
diff --git a/tools/perf/page_sets/tough_pinch_zoom_cases.py b/tools/perf/page_sets/tough_pinch_zoom_cases.py
index a0067d154c78272351b81856389c105124ff296a..e6601e3a1a0354b39afb41fe53d432c3edcc75ab 100644
--- a/tools/perf/page_sets/tough_pinch_zoom_cases.py
+++ b/tools/perf/page_sets/tough_pinch_zoom_cases.py
@@ -15,10 +15,8 @@ class ToughPinchZoomCasesPage(page_module.Page):
self.archive_data_file = 'data/tough_pinch_zoom_cases.json'
def RunPageInteractions(self, action_runner):
- interaction = action_runner.BeginGestureInteraction(
- 'PinchAction')
- action_runner.PinchPage()
- interaction.End()
+ with action_runner.CreateGestureInteraction('PinchAction'):
+ action_runner.PinchPage()
class GoogleSearchPage(ToughPinchZoomCasesPage):
@@ -69,10 +67,8 @@ class GoogleCalendarPage(ToughPinchZoomCasesPage):
action_runner.Wait(2)
def RunPageInteractions(self, action_runner):
- interaction = action_runner.BeginGestureInteraction(
- 'PinchAction')
- action_runner.PinchPage(left_anchor_ratio=0.1, top_anchor_ratio=0.3)
- interaction.End()
+ with action_runner.CreateGestureInteraction('PinchAction'):
+ action_runner.PinchPage(left_anchor_ratio=0.1, top_anchor_ratio=0.3)
class GoogleImageSearchPage(ToughPinchZoomCasesPage):
@@ -103,10 +99,9 @@ class GooglePlusPage(ToughPinchZoomCasesPage):
action_runner.WaitForElement(text='Home')
def RunPageInteractions(self, action_runner):
- interaction = action_runner.BeginGestureInteraction(
- 'PinchAction')
- action_runner.PinchElement(selector='[id="110031535020051778989-tab-bar"]')
- interaction.End()
+ with action_runner.CreateGestureInteraction('PinchAction'):
+ action_runner.PinchElement(
+ selector='[id="110031535020051778989-tab-bar"]')
class YoutubePage(ToughPinchZoomCasesPage):
@@ -234,10 +229,8 @@ class YahooAnswersPage(ToughPinchZoomCasesPage):
page_set=page_set)
def RunPageInteractions(self, action_runner):
- interaction = action_runner.BeginGestureInteraction(
- 'PinchAction')
- action_runner.PinchElement(selector='#ya-content-apps')
- interaction.End()
+ with action_runner.CreateGestureInteraction('PinchAction'):
+ action_runner.PinchElement(selector='#ya-content-apps')
class ToughPinchZoomCasesPageSet(page_set_module.PageSet):
« no previous file with comments | « tools/perf/page_sets/top_7_stress.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698