Issue 1058013003: Unbreak widgets_app.dart (by disabling PopupMenu for now)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1058013003: Unbreak widgets_app.dart (by disabling PopupMenu for now) (Closed)

Created:
5 years, 8 months ago by eseidel

Modified:
5 years, 8 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Unbreak widgets_app.dart (by disabling PopupMenu for now) Also fix button.dart to include ink_well.dart. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bc7145f9d86234ae45b81267e96add5776add9c1

Patch Set 1 #

Total comments: 1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -18 lines)			Patch
	M	sky/examples/widgets/widgets_app.dart	View		1 chunk	+24 lines, -18 lines	1 comment	Download
	M	sky/framework/components/button.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ojan

https://codereview.chromium.org/1058013003/diff/1/sky/examples/widgets/widgets_app.dart File sky/examples/widgets/widgets_app.dart (right): https://codereview.chromium.org/1058013003/diff/1/sky/examples/widgets/widgets_app.dart#newcode25 sky/examples/widgets/widgets_app.dart:25: // PopupMenu requires a PopupMenuController and should be wired ...

5 years, 8 months ago (2015-04-06 23:07:11 UTC) #2

eseidel

On 2015/04/06 at 23:07:11, ojan wrote: > https://codereview.chromium.org/1058013003/diff/1/sky/examples/widgets/widgets_app.dart > File sky/examples/widgets/widgets_app.dart (right): > > https://codereview.chromium.org/1058013003/diff/1/sky/examples/widgets/widgets_app.dart#newcode25 ...

5 years, 8 months ago (2015-04-06 23:08:52 UTC) #3

eseidel

5 years, 8 months ago (2015-04-07 18:17:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bc7145f9d86234ae45b81267e96add5776add9c1 (presubmit successful).

Expand Messages | Collapse Messages