Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: sky/examples/widgets/widgets_app.dart

Issue 1058013003: Unbreak widgets_app.dart (by disabling PopupMenu for now) (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/framework/components/button.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/widgets/widgets_app.dart
diff --git a/sky/examples/widgets/widgets_app.dart b/sky/examples/widgets/widgets_app.dart
index da3491116648d5604370bf9ca559c7118bf84e4b..33d39caaaf84828d582781993199f5c1df11df0a 100644
--- a/sky/examples/widgets/widgets_app.dart
+++ b/sky/examples/widgets/widgets_app.dart
@@ -13,29 +13,35 @@ class WidgetsApp extends App {
top: 200px;
left: 200px;''');
+ PopupMenuController controller;
+
UINode build() {
return new Container(
children: [
new Button(key: 'Go', content: new Text('Go'), level: 1),
new Button(key: 'Back', content: new Text('Back'), level: 3),
- new Input(),
- new Container(
- style: _menuStyle,
- children: [
- new PopupMenu(
- items: [
- [new Text('People & options')],
- [new Text('New group conversation')],
- [new Text('Turn history off')],
- [new Text('Archive')],
- [new Text('Delete')],
- [new Text('Un-merge SMS')],
- [new Text('Help & feeback')],
- ],
- level: 4),
- ]
- )
- ]
+ new Input()
+
+ // PopupMenu requires a PopupMenuController and should be wired up
ojan 2015/04/06 23:07:10 Maybe just delete the code? Or add a TODO?
+ // to a button to create the controller only when the menu is open, etc.
+ // new Container(
+ // style: _menuStyle,
+ // children: [
+ // new PopupMenu(
+ // controller: controller,
+ // items: [
+ // [new Text('People & options')],
+ // [new Text('New group conversation')],
+ // [new Text('Turn history off')],
+ // [new Text('Archive')],
+ // [new Text('Delete')],
+ // [new Text('Un-merge SMS')],
+ // [new Text('Help & feeback')],
+ // ],
+ // level: 4),
+ // ]
+ // )
+ // ]
);
}
}
« no previous file with comments | « no previous file | sky/framework/components/button.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698