Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1057993004: Revert of Work on Windows GN component build. (Closed)

Created:
5 years, 8 months ago by pkotwicz
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Work on Windows GN component build. (patchset #8 id:140001 of https://codereview.chromium.org/1053203003/) Reason for revert: Reverting the CL because I think that it broke the GN compile on Linux - See http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/26255/steps/compile/logs/stdio Original issue's description: > Work on Windows GN component build. > > This makes ppapi_shared link. This required many changes to gpu to match the structure of GYP in both component and non-component modes. > > BUG=470212 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg > > Committed: https://crrev.com/b3c7880dc9e66ff449b23e2273b4f20abecba442 > Cr-Commit-Position: refs/heads/master@{#323937} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=470212 Committed: https://crrev.com/59639a8ae80d96e4083be7a19865de32bbf798bc Cr-Commit-Position: refs/heads/master@{#323942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -148 lines) Patch
M components/nacl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/BUILD.gn View 3 chunks +3 lines, -6 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M gpu/blink/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/BUILD.gn View 3 chunks +20 lines, -36 lines 0 comments Download
M gpu/command_buffer/common/BUILD.gn View 1 chunk +1 line, -19 lines 0 comments Download
M gpu/command_buffer/service/BUILD.gn View 3 chunks +6 lines, -16 lines 0 comments Download
M gpu/config/BUILD.gn View 2 chunks +2 lines, -16 lines 0 comments Download
M gpu/ipc/BUILD.gn View 2 chunks +2 lines, -16 lines 0 comments Download
M media/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/BUILD.gn View 2 chunks +2 lines, -14 lines 0 comments Download
M ppapi/shared_impl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/BUILD.gn View 2 chunks +1 line, -13 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/surface/BUILD.gn View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pkotwicz
Created Revert of Work on Windows GN component build.
5 years, 8 months ago (2015-04-06 20:34:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057993004/1
5 years, 8 months ago (2015-04-06 20:35:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 20:36:25 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 20:37:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/59639a8ae80d96e4083be7a19865de32bbf798bc
Cr-Commit-Position: refs/heads/master@{#323942}

Powered by Google App Engine
This is Rietveld 408576698