Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: gpu/command_buffer/client/BUILD.gn

Issue 1057993004: Revert of Work on Windows GN component build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/blink/BUILD.gn ('k') | gpu/command_buffer/common/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/client/BUILD.gn
diff --git a/gpu/command_buffer/client/BUILD.gn b/gpu/command_buffer/client/BUILD.gn
index bbb7c0b99d1de1309dbc17f71a92ff2c804b229b..fabc82a0fe29c7fbf37528a71882715a622718b1 100644
--- a/gpu/command_buffer/client/BUILD.gn
+++ b/gpu/command_buffer/client/BUILD.gn
@@ -2,38 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
-# The files here go into the "gpu" component in a component build (with
-# "command_buffer_client" and "gles2_cmd_helper" just forwarding) and goes into
-# separate static libraries in non-component build. This needs to match the
-# GYP build which was likely an attempt to make larger components to help with
-# loading.
-group("client") {
- if (is_component_build) {
- public_deps = [
- "//gpu",
- ]
- } else {
- public_deps = [
- ":client_sources",
- ]
- }
-}
-
-group("gles2_cmd_helper") {
- if (is_component_build) {
- public_deps = [
- "//gpu",
- ]
- } else {
- public_deps = [
- ":gles2_cmd_helper_sources",
- ]
- }
-}
-
-source_set("client_sources") {
- visibility = [ "//gpu/*" ]
-
+source_set("client") {
sources = [
"cmd_buffer_helper.cc",
"cmd_buffer_helper.h",
@@ -59,12 +28,27 @@
all_dependent_configs = [ "//third_party/khronos:khronos_headers" ]
deps = [
- "//gpu/command_buffer/common:common_sources",
- ]
+ "//gpu/command_buffer/common",
+ ]
+}
+
+group("gles2_cmd_helper") {
+ if (is_component_build) {
+ deps = [
+ "//gpu",
+ ]
+ } else {
+ deps = [
+ ":gles2_cmd_helper_sources",
+ ]
+ }
}
source_set("gles2_cmd_helper_sources") {
- visibility = [ "//gpu/*" ]
+ visibility = [
+ ":gles2_cmd_helper",
+ "//gpu",
+ ]
sources = [
"gles2_cmd_helper.cc",
"gles2_cmd_helper.h",
@@ -78,7 +62,7 @@
]
deps = [
- ":client_sources",
+ ":client",
]
}
« no previous file with comments | « gpu/blink/BUILD.gn ('k') | gpu/command_buffer/common/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698