UseCounter for File.lastModifiedDate.

UseCounter for File.lastModifiedDate.

The latest ED for the File API prescribes a lastModified attribute that
returns a number and removes the lastModifiedDate that returned a date.
This will help us decide if we can deprecate and remove the old
attribute.

TEST=Chromium compiles.
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163211

[pwnall-personal, 2013-12-04 23:38:32]

Please take a look?

I kept punting on this while waiting for the discussion behind my latest File
constructor CL to settle, but I figured we should start counting :)

[kinuko, 2013-12-05 01:16:40]

LGTM
2013/12/05 8:38 <costan@gmail.com>:

> Reviewers: kinuko,
>
> Message:
> Please take a look?
>
> I kept punting on this while waiting for the discussion behind my latest
> File
> constructor CL to settle, but I figured we should start counting :)
>
> Description:
> UseCounter for File.lastModifiedDate.
>
> The latest ED for the File API prescribes a lastModified attribute that
> returns a number and removes the lastModifiedDate that returned a date.
> This will help us decide if we can deprecate and remove the old
> attribute.
>
> TEST=Chromium compiles.
> BUG=
>
> Please review this at https://codereview.chromium.org/105763002/
>
> SVN Base: https://chromium.googlesource.com/chromium/blink.git@master
>
> Affected files (+2, -1 lines):
>   M Source/core/fileapi/File.idl
>   M Source/core/frame/UseCounter.h
>
>
> Index: Source/core/fileapi/File.idl
> diff --git a/Source/core/fileapi/File.idl b/Source/core/fileapi/File.idl
> index fdbe18db4fdda887c85918bd421123a17754e777..
> a7eab6e478fb920cd4e12003d1b16cbe6f39ba35 100644
> --- a/Source/core/fileapi/File.idl
> +++ b/Source/core/fileapi/File.idl
> @@ -28,7 +28,7 @@
>      CustomConstructor(sequence<any> blobParts, DOMString fileName,
> optional BlobPropertyBag options)
>  ] interface File : Blob {
>      readonly attribute DOMString name;
> -    readonly attribute Date lastModifiedDate;
> +    [MeasureAs=FileGetLastModifiedDate] readonly attribute Date
> lastModifiedDate;
>      [RuntimeEnabled=DirectoryUpload] readonly attribute DOMString
> webkitRelativePath;
>  };
>
> Index: Source/core/frame/UseCounter.h
> diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/
> UseCounter.h
> index 8640517a5b3ee08a962d91c88b149f6ea8cefe7c..
> 72e220c49a66f225263a829f81c19862e97ee84b 100644
> --- a/Source/core/frame/UseCounter.h
> +++ b/Source/core/frame/UseCounter.h
> @@ -268,6 +268,7 @@ public:
>          IsIndexElement,
>          HTMLHeadElementProfile,
>          OverflowChangedEvent,
> +        FileGetLastModifiedDate,
>          // Add new features immediately above this line. Don't change
> assigned
>          // numbers of each items, and don't reuse unused slots.
>          NumberOfFeatures, // This enum value must be last.
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-12-05 01:27:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/costan@gmail.com/105763002/20001

[commit-bot: I haz the power, 2013-12-05 01:27:15]

Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/frame/UseCounter.h
  Hunk #1 FAILED at 270.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej

Patch:       Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
ca08b4fcea668b9de2411ce18ee5be913f8e047f..d55227dea2c8b57417ff8507ce48c05289f7b4a4
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -270,6 +270,7 @@ public:
         OverflowChangedEvent,
         SVGPointMatrixTransform,
         HTMLHtmlElementManifest,
+        FileGetLastModifiedDate,
         // Add new features immediately above this line. Don't change assigned
         // numbers of each items, and don't reuse unused slots.
         NumberOfFeatures, // This enum value must be last.

[commit-bot: I haz the power, 2013-12-05 01:29:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/costan@gmail.com/105763002/40001

[commit-bot: I haz the power, 2013-12-05 02:54:15]

Change committed as 163211