Source/core/dom/ElementRareData.cpp - Issue 1057603002: Expose scroll customization for touch to JS (behind REF).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ElementRareData.cpp

Issue 1057603002: Expose scroll customization for touch to JS (behind REF). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address haraken's comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/dom/ElementRareData.h ('K') | « Source/core/dom/ElementRareData.h ('k') | Source/core/input/EventHandler.cpp » ('j') | Source/core/page/scrolling/ScrollStateCallback.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/ElementRareData.cpp

diff --git a/Source/core/dom/ElementRareData.cpp b/Source/core/dom/ElementRareData.cpp

index 08934494c16d767e836bef33f315ebc46ac14930..959f073307dcd4b33abafa5c459982d033755dcd 100644

--- a/Source/core/dom/ElementRareData.cpp

+++ b/Source/core/dom/ElementRareData.cpp

@@ -40,6 +40,7 @@ struct SameSizeAsElementRareData : NodeRareData {

LayoutSize sizeForResizing;

IntSize scrollOffset;

void* pointers[13];

+ PersistentWillBeMember<Element> persistentWillBeMember[2];

haraken 2015/06/30 07:08:30 This looks like an unacceptable size increase. Let

};

CSSStyleDeclaration& ElementRareData::ensureInlineCSSStyleDeclaration(Element* ownerElement)

@@ -72,6 +73,8 @@ DEFINE_TRACE_AFTER_DISPATCH(ElementRareData)

visitor->trace(m_generatedAfter);

visitor->trace(m_generatedFirstLetter);

visitor->trace(m_backdrop);

+ visitor->trace(m_applyScroll);

+ visitor->trace(m_distributeScroll);

NodeRareData::traceAfterDispatch(visitor);

}

« Source/core/dom/ElementRareData.h ('K') | « Source/core/dom/ElementRareData.h ('k') | Source/core/input/EventHandler.cpp » ('j') | Source/core/page/scrolling/ScrollStateCallback.cpp » ('J')