Source/core/dom/ElementRareData.cpp - Issue 1057603002: Expose scroll customization for touch to JS (behind REF).

Side by Side Diff: Source/core/dom/ElementRareData.cpp

Issue 1057603002: Expose scroll customization for touch to JS (behind REF). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address haraken's comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 22 matching lines...) Expand all Loading...
33	33

34 #include "core/style/ComputedStyle.h"	34 #include "core/style/ComputedStyle.h"

35	35

36 namespace blink {	36 namespace blink {

37	37

38 struct SameSizeAsElementRareData : NodeRareData {	38 struct SameSizeAsElementRareData : NodeRareData {

39 short indices[2];	39 short indices[2];

40 LayoutSize sizeForResizing;	40 LayoutSize sizeForResizing;

41 IntSize scrollOffset;	41 IntSize scrollOffset;

42 void* pointers[13];	42 void* pointers[13];

	43 PersistentWillBeMember<Element> persistentWillBeMember[2];
	haraken 2015/06/30 07:08:30 This looks like an unacceptable size increase. Let This looks like an unacceptable size increase. Let's revisit this issue once we resolve other concerns in this CL. FWIW, I'm tring to reduce sizeof(Persistent) here: https://codereview.chromium.org/1213133002/
43 };	44 };

44	45

45 CSSStyleDeclaration& ElementRareData::ensureInlineCSSStyleDeclaration(Element* o wnerElement)	46 CSSStyleDeclaration& ElementRareData::ensureInlineCSSStyleDeclaration(Element* o wnerElement)

46 {	47 {

47 if (!m_cssomWrapper)	48 if (!m_cssomWrapper)

48 m_cssomWrapper = adoptPtrWillBeNoop(new InlineCSSStyleDeclaration(ownerE lement));	49 m_cssomWrapper = adoptPtrWillBeNoop(new InlineCSSStyleDeclaration(ownerE lement));

49 return *m_cssomWrapper;	50 return *m_cssomWrapper;

50 }	51 }

51	52

52 AttrNodeList& ElementRareData::ensureAttrNodeList()	53 AttrNodeList& ElementRareData::ensureAttrNodeList()

(...skipping 12 matching lines...) Expand all Loading...
65 #if ENABLE(OILPAN)	66 #if ENABLE(OILPAN)

66 visitor->trace(m_attrNodeList);	67 visitor->trace(m_attrNodeList);

67 #endif	68 #endif

68 visitor->trace(m_elementAnimations);	69 visitor->trace(m_elementAnimations);

69 visitor->trace(m_cssomWrapper);	70 visitor->trace(m_cssomWrapper);

70 visitor->trace(m_customElementDefinition);	71 visitor->trace(m_customElementDefinition);

71 visitor->trace(m_generatedBefore);	72 visitor->trace(m_generatedBefore);

72 visitor->trace(m_generatedAfter);	73 visitor->trace(m_generatedAfter);

73 visitor->trace(m_generatedFirstLetter);	74 visitor->trace(m_generatedFirstLetter);

74 visitor->trace(m_backdrop);	75 visitor->trace(m_backdrop);

	76 visitor->trace(m_applyScroll);

	77 visitor->trace(m_distributeScroll);

75 NodeRareData::traceAfterDispatch(visitor);	78 NodeRareData::traceAfterDispatch(visitor);

76 }	79 }

77	80

78 static_assert(sizeof(ElementRareData) == sizeof(SameSizeAsElementRareData), "Ele mentRareData should stay small");	81 static_assert(sizeof(ElementRareData) == sizeof(SameSizeAsElementRareData), "Ele mentRareData should stay small");

79	82

80 } // namespace blink	83 } // namespace blink

OLD	NEW

« Source/core/dom/ElementRareData.h ('K') | « Source/core/dom/ElementRareData.h ('k') | Source/core/input/EventHandler.cpp » ('j') | Source/core/page/scrolling/ScrollStateCallback.cpp » ('J')