components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h - Issue 1057473003: Remove BooleanPrefMember usage from Data Reduction Proxy IO classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h

Issue 1057473003: Remove BooleanPrefMember usage from Data Reduction Proxy IO classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bengr CR comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h

index efff8d1166dcc0105feeda74bf9d99cc493d4b46..dcec95e2c05d7171c386b3a59b0c5262dfe6b8ef 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h

@@ -6,7 +6,6 @@

#define COMPONENTS_DATA_REDUCTION_PROXY_CORE_BROWSER_DATA_REDUCTION_PROXY_BYPASS_STATS_H_

#include "base/callback.h"

-#include "base/prefs/pref_member.h"

#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"

#include "net/base/host_port_pair.h"

#include "net/base/network_change_notifier.h"

@@ -68,7 +67,7 @@ class DataReductionProxyBypassStats

// completed URLRequest |request|.

void RecordBytesHistograms(

const net::URLRequest& request,

- const BooleanPrefMember& data_reduction_proxy_enabled,

+ bool data_reduction_proxy_enabled,

const net::ProxyConfig& data_reduction_proxy_config);

// Called by |ChromeNetworkDelegate| when a proxy is put into the bad proxy

@@ -104,7 +103,7 @@ class DataReductionProxyBypassStats

// tells us the state of the kDataReductionProxyEnabled preference.

void RecordBypassedBytesHistograms(

const net::URLRequest& request,

- const BooleanPrefMember& data_reduction_proxy_enabled,

+ bool data_reduction_proxy_enabled,

const net::ProxyConfig& data_reduction_proxy_config);

// Records UMA of the number of response bytes of responses that are expected