Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc

Issue 1057473003: Remove BooleanPrefMember usage from Data Reduction Proxy IO classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: bengr CR comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
index 87e94d218dcf43c89f843f0b06ecf032edde9552..d17965717789f81b9ab2ff0ddeee247157e30a14 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.cc
@@ -7,7 +7,6 @@
#include "base/callback.h"
#include "base/metrics/histogram.h"
#include "base/metrics/sparse_histogram.h"
-#include "base/prefs/pref_member.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h"
#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.h"
#include "components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h"
@@ -170,7 +169,7 @@ DataReductionProxyBypassStats::GetBypassType() const {
void DataReductionProxyBypassStats::RecordBytesHistograms(
const net::URLRequest& request,
- const BooleanPrefMember& data_reduction_proxy_enabled,
+ bool data_reduction_proxy_enabled,
const net::ProxyConfig& data_reduction_proxy_config) {
RecordBypassedBytesHistograms(request, data_reduction_proxy_enabled,
data_reduction_proxy_config);
@@ -226,12 +225,12 @@ void DataReductionProxyBypassStats::OnConnectComplete(
void DataReductionProxyBypassStats::RecordBypassedBytesHistograms(
const net::URLRequest& request,
- const BooleanPrefMember& data_reduction_proxy_enabled,
+ bool data_reduction_proxy_enabled,
const net::ProxyConfig& data_reduction_proxy_config) {
int64 content_length = request.received_response_content_length();
// Only record histograms when the data reduction proxy is enabled.
- if (!data_reduction_proxy_enabled.GetValue())
+ if (!data_reduction_proxy_enabled)
return;
// TODO(bengr): Add histogram(s) for byte counts of unsupported schemes, e.g.,

Powered by Google App Engine
This is Rietveld 408576698