 Chromium Code Reviews
 Chromium Code Reviews Issue 1057453002:
  bindings: Throw TypeError when required dictionary member is undefined  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 1057453002:
  bindings: Throw TypeError when required dictionary member is undefined  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h | 
| diff --git a/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h b/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h | 
| index 0014bceb573527a96cfcad135c518b76fa0ff4df..4a0117c559ddf77ecbae4daa86c4dcfb1a8251db 100644 | 
| --- a/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h | 
| +++ b/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h | 
| @@ -7,6 +7,7 @@ | 
| #ifndef TestDictionaryDerivedImplementedAs_h | 
| #define TestDictionaryDerivedImplementedAs_h | 
| +#include "bindings/core/v8/Nullable.h" | 
| #include "bindings/tests/idls/core/TestDictionary.h" | 
| #include "platform/heap/Handle.h" | 
| #include "wtf/text/WTFString.h" | 
| @@ -26,11 +27,16 @@ public: | 
| String derivedStringMemberWithDefault() const { return m_derivedStringMemberWithDefault; } | 
| void setDerivedStringMemberWithDefault(String value) { m_derivedStringMemberWithDefault = value; } | 
| + bool hasRequiredLongMember() const { return !m_requiredLongMember.isNull(); } | 
| 
Jens Widell
2015/04/01 10:06:20
Slightly weird to have this for required members,
 
bashi
2015/04/01 10:42:15
Yeah, and dictionaries can be used as a return val
 | 
| + int requiredLongMember() const { return m_requiredLongMember.get(); } | 
| + void setRequiredLongMember(int value) { m_requiredLongMember = value; } | 
| + | 
| DECLARE_VIRTUAL_TRACE(); | 
| private: | 
| String m_derivedStringMember; | 
| String m_derivedStringMemberWithDefault; | 
| + Nullable<int> m_requiredLongMember; | 
| friend class V8TestDictionaryDerivedImplementedAs; | 
| }; |