 Chromium Code Reviews
 Chromium Code Reviews Issue 1057453002:
  bindings: Throw TypeError when required dictionary member is undefined  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 1057453002:
  bindings: Throw TypeError when required dictionary member is undefined  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW | 
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be | 
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. | 
| 4 | 4 | 
| 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! | 5 // This file has been auto-generated by code_generator_v8.py. DO NOT MODIFY! | 
| 6 | 6 | 
| 7 #ifndef TestDictionaryDerivedImplementedAs_h | 7 #ifndef TestDictionaryDerivedImplementedAs_h | 
| 8 #define TestDictionaryDerivedImplementedAs_h | 8 #define TestDictionaryDerivedImplementedAs_h | 
| 9 | 9 | 
| 10 #include "bindings/core/v8/Nullable.h" | |
| 10 #include "bindings/tests/idls/core/TestDictionary.h" | 11 #include "bindings/tests/idls/core/TestDictionary.h" | 
| 11 #include "platform/heap/Handle.h" | 12 #include "platform/heap/Handle.h" | 
| 12 #include "wtf/text/WTFString.h" | 13 #include "wtf/text/WTFString.h" | 
| 13 | 14 | 
| 14 namespace blink { | 15 namespace blink { | 
| 15 | 16 | 
| 16 class TestDictionaryDerivedImplementedAs : public TestDictionary { | 17 class TestDictionaryDerivedImplementedAs : public TestDictionary { | 
| 17 ALLOW_ONLY_INLINE_ALLOCATION(); | 18 ALLOW_ONLY_INLINE_ALLOCATION(); | 
| 18 public: | 19 public: | 
| 19 TestDictionaryDerivedImplementedAs(); | 20 TestDictionaryDerivedImplementedAs(); | 
| 20 | 21 | 
| 21 bool hasDerivedStringMember() const { return !m_derivedStringMember.isNull() ; } | 22 bool hasDerivedStringMember() const { return !m_derivedStringMember.isNull() ; } | 
| 22 String derivedStringMember() const { return m_derivedStringMember; } | 23 String derivedStringMember() const { return m_derivedStringMember; } | 
| 23 void setDerivedStringMember(String value) { m_derivedStringMember = value; } | 24 void setDerivedStringMember(String value) { m_derivedStringMember = value; } | 
| 24 | 25 | 
| 25 bool hasDerivedStringMemberWithDefault() const { return !m_derivedStringMemb erWithDefault.isNull(); } | 26 bool hasDerivedStringMemberWithDefault() const { return !m_derivedStringMemb erWithDefault.isNull(); } | 
| 26 String derivedStringMemberWithDefault() const { return m_derivedStringMember WithDefault; } | 27 String derivedStringMemberWithDefault() const { return m_derivedStringMember WithDefault; } | 
| 27 void setDerivedStringMemberWithDefault(String value) { m_derivedStringMember WithDefault = value; } | 28 void setDerivedStringMemberWithDefault(String value) { m_derivedStringMember WithDefault = value; } | 
| 28 | 29 | 
| 30 bool hasRequiredLongMember() const { return !m_requiredLongMember.isNull(); } | |
| 
Jens Widell
2015/04/01 10:06:20
Slightly weird to have this for required members,
 
bashi
2015/04/01 10:42:15
Yeah, and dictionaries can be used as a return val
 | |
| 31 int requiredLongMember() const { return m_requiredLongMember.get(); } | |
| 32 void setRequiredLongMember(int value) { m_requiredLongMember = value; } | |
| 33 | |
| 29 DECLARE_VIRTUAL_TRACE(); | 34 DECLARE_VIRTUAL_TRACE(); | 
| 30 | 35 | 
| 31 private: | 36 private: | 
| 32 String m_derivedStringMember; | 37 String m_derivedStringMember; | 
| 33 String m_derivedStringMemberWithDefault; | 38 String m_derivedStringMemberWithDefault; | 
| 39 Nullable<int> m_requiredLongMember; | |
| 34 | 40 | 
| 35 friend class V8TestDictionaryDerivedImplementedAs; | 41 friend class V8TestDictionaryDerivedImplementedAs; | 
| 36 }; | 42 }; | 
| 37 | 43 | 
| 38 } // namespace blink | 44 } // namespace blink | 
| 39 | 45 | 
| 40 #endif // TestDictionaryDerivedImplementedAs_h | 46 #endif // TestDictionaryDerivedImplementedAs_h | 
| OLD | NEW |