Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2059)

Unified Diff: pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

Issue 1057403003: fix keyword completion in class body (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart b/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
index f688f2fa0100ec573e5bcbd7e328ea2e8abf86e3..85ca966813280e06c7e5761947b6e57dc3fc3e34 100644
--- a/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
+++ b/pkg/analysis_server/lib/src/services/completion/keyword_computer.dart
@@ -70,7 +70,7 @@ class _KeywordVisitor extends GeneralizingAstVisitor {
if (entity == node.name) {
return;
}
- if (entity == node.rightBracket) {
+ if (entity == node.rightBracket || node.members.contains(entity)) {
Paul Berry 2015/04/03 21:20:51 Nit: since request.target.containingNode is always
danrubel 2015/04/03 22:10:40 Good suggestion. Done.
_addSuggestions([
Keyword.CONST,
Keyword.DYNAMIC,
« no previous file with comments | « no previous file | pkg/analysis_server/test/completion_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698