fix keyword completion in class body

pkg/analysis_server/lib/src/services/completion/keyword_computer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.computer.dart.keyword;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
@@ skipping 52 matching lines @@
       Keyword.WHILE
     ]);
   }
 
   @override
   visitClassDeclaration(ClassDeclaration node) {
     // Don't suggest class name
     if (entity == node.name) {
       return;
     }
-    if (entity == node.rightBracket) {
+    if (entity == node.rightBracket || node.members.contains(entity)) {

[Paul Berry, 2015/04/03 21:20:51]

Nit: since request.target.containingNode is always the parent of
request.target.entity, you don't need to search through the node to check
whether entity is one of its members.  It should be sufficient just to do:

if (entity == node.rightBracket || entity is ClassMember)

[danrubel, 2015/04/03 22:10:40]

Good suggestion. Done.

       _addSuggestions([
         Keyword.CONST,
         Keyword.DYNAMIC,
         Keyword.FACTORY,
         Keyword.FINAL,
         Keyword.GET,
         Keyword.OPERATOR,
         Keyword.SET,
         Keyword.STATIC,
         Keyword.VAR,
@@ skipping 77 matching lines @@
         return false;
       }
       AstNode parent = body.parent;
       if (parent is ConstructorDeclaration || parent is MethodDeclaration) {
         return true;
       }
       node = parent;
     }
   }
 }