Fix nits.

Fix nits from previous code review: https://codereview.chromium.org/1048733004/.

BUG=471829
Committed: https://crrev.com/23787872ff5e47bdab1653454df5bffa00a85cf3
Cr-Commit-Position: refs/heads/master@{#323832}

[shrike, 2015-04-03 20:41:36]

shrike@chromium.org changed reviewers:
+ rsesek@chromium.org

[shrike, 2015-04-03 20:44:46]

PTAL

[Robert Sesek, 2015-04-03 21:00:05]

Last few comments. Nice job!

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
File chrome/browser/ui/cocoa/spinner_view.mm (right):

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
chrome/browser/ui/cocoa/spinner_view.mm:149: [animationValues
addObject:@(-(kArcLength - 0.4) * scaleFactor)];
It looks like animationValues need not be mutable either, and you can use the
@[] syntax like for keyTimes below.

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
chrome/browser/ui/cocoa/spinner_view.mm:165: [animationValues addObject:@(0.0)];
Same, animationValues = @[ @(0.0) ];

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
chrome/browser/ui/cocoa/spinner_view.mm:204: [animationValues addObject:@(0.0)];
Again, use @[]

[shrike, 2015-04-03 21:11:33]

PTAL

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
File chrome/browser/ui/cocoa/spinner_view.mm (right):

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
chrome/browser/ui/cocoa/spinner_view.mm:149: [animationValues
addObject:@(-(kArcLength - 0.4) * scaleFactor)];
On 2015/04/03 21:00:05, Robert Sesek wrote:
> It looks like animationValues need not be mutable either, and you can use the
> @[] syntax like for keyTimes below.

Done.

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
chrome/browser/ui/cocoa/spinner_view.mm:165: [animationValues addObject:@(0.0)];
On 2015/04/03 21:00:05, Robert Sesek wrote:
> Same, animationValues = @[ @(0.0) ];

Done.

https://codereview.chromium.org/1057393003/diff/1/chrome/browser/ui/cocoa/spi...
chrome/browser/ui/cocoa/spinner_view.mm:204: [animationValues addObject:@(0.0)];
On 2015/04/03 21:00:05, Robert Sesek wrote:
> Again, use @[]

Done.

[Robert Sesek, 2015-04-03 21:28:35]

LGTM!

https://codereview.chromium.org/1057393003/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/spinner_view.mm (right):

https://codereview.chromium.org/1057393003/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/spinner_view.mm:205: @(-4.0 * kDegrees360 +
kDegrees270)];
nit: space before last ]

[shrike, 2015-04-03 21:47:55]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2015-04-03 21:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1057393003/20001

[commit-bot: I haz the power, 2015-04-03 22:27:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-03 22:28:34]

Patchset 2 (id:??) landed as
https://crrev.com/23787872ff5e47bdab1653454df5bffa00a85cf3
Cr-Commit-Position: refs/heads/master@{#323832}