Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: runtime/observatory/lib/src/elements/function_view.html

Issue 1057333004: Continue improving the documentation for the vm service protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/function_view.html
diff --git a/runtime/observatory/lib/src/elements/function_view.html b/runtime/observatory/lib/src/elements/function_view.html
index 519cad8504349e1051cad883e5dc9f26b1b56b4e..4b75c5c33d7fa09089bb65ae82ba9eaefad8bc2b 100644
--- a/runtime/observatory/lib/src/elements/function_view.html
+++ b/runtime/observatory/lib/src/elements/function_view.html
@@ -14,12 +14,9 @@
<nav-bar>
<top-nav-menu></top-nav-menu>
<isolate-nav-menu isolate="{{ function.isolate }}"></isolate-nav-menu>
- <template if="{{ function.owningClass != null }}">
- <!-- TODO(turnidge): Add library nav menu here. -->
- <class-nav-menu cls="{{ function.owningClass }}"></class-nav-menu>
- </template>
- <template if="{{ function.owningLibrary != null }}">
- <library-nav-menu library="{{ function.owningLibrary }}"></library-nav-menu>
+ <library-nav-menu library="{{ function.library }}"></library-nav-menu>
+ <template if="{{ function.dartOwner is ServiceClass }}">
+ <class-nav-menu cls="{{ function.dartOwner }}"></class-nav-menu>
</template>
<nav-menu link="{{ makeLink('/inspect', function) }}" anchor="{{ function.name }}" last="{{ true }}"></nav-menu>
<nav-refresh callback="{{ refreshCoverage }}" label="Refresh Coverage"></nav-refresh>
@@ -39,23 +36,10 @@
{{ function.kind.toString() }}
</div>
</div>
- <template if="{{ function.parent != null }}">
- <div class="memberItem">
- <div class="memberName">parent function</div>
- <div class="memberValue">
- <function-ref ref="{{ function.parent }}"></function-ref>
- </div>
- </div>
- </template>
<div class="memberItem">
<div class="memberName">owner</div>
<div class="memberValue">
- <template if="{{ function.owningClass != null }}">
- <class-ref ref="{{ function.owningClass }}"></class-ref>
- </template>
- <template if="{{ function.owningLibrary != null }}">
- <library-ref ref="{{ function.owningLibrary }}"></library-ref>
- </template>
+ <any-service-ref ref="{{ function.dartOwner }}"></any-service-ref>
</div>
</div>
<div class="memberItem">
« no previous file with comments | « runtime/observatory/lib/src/elements/function_ref.dart ('k') | runtime/observatory/lib/src/elements/instance_ref.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698