Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: runtime/observatory/lib/src/elements/function_ref.dart

Issue 1057333004: Continue improving the documentation for the vm service protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/function_ref.dart
diff --git a/runtime/observatory/lib/src/elements/function_ref.dart b/runtime/observatory/lib/src/elements/function_ref.dart
index 2e92f60919199414b2ea60b63ccf034c4fc71add..53920b97452473811cacd20af6b64571053ad83e 100644
--- a/runtime/observatory/lib/src/elements/function_ref.dart
+++ b/runtime/observatory/lib/src/elements/function_ref.dart
@@ -28,18 +28,17 @@ class FunctionRefElement extends ServiceRefElement {
}
if (function.isDart) {
if (qualified) {
- // Add class-name or parent-function-name followed by a dot.
- if ((function.parent == null) && (function.owningClass != null)) {
- var classRef = new Element.tag('class-ref');
- classRef.ref = function.owningClass;
- shadowRoot.children.add(classRef);
- insertTextSpanIntoShadowRoot('.');
- } else if (function.parent != null) {
+ if (function.dartOwner is ServiceFunction) {
var functionRef = new Element.tag('function-ref');
- functionRef.ref = function.parent;
+ functionRef.ref = function.dartOwner;
functionRef.qualified = true;
shadowRoot.children.add(functionRef);
insertTextSpanIntoShadowRoot('.');
+ } else if (function.dartOwner is Class) {
+ var classRef = new Element.tag('class-ref');
+ classRef.ref = function.dartOwner;
+ shadowRoot.children.add(classRef);
+ insertTextSpanIntoShadowRoot('.');
}
}
insertLinkIntoShadowRoot(name, url, hoverText);
« no previous file with comments | « runtime/observatory/lib/src/elements/field_view.html ('k') | runtime/observatory/lib/src/elements/function_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698