Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: runtime/observatory/lib/src/elements/field_view.html

Issue 1057333004: Continue improving the documentation for the vm service protocol. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/isolate.cc ('k') | runtime/observatory/lib/src/elements/function_ref.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/field_view.html
diff --git a/runtime/observatory/lib/src/elements/field_view.html b/runtime/observatory/lib/src/elements/field_view.html
index 2a9d728343902c0c98a299e7f1d67532cad1d429..cad31aa860e84456d9b260c30e05f2f487d9d317 100644
--- a/runtime/observatory/lib/src/elements/field_view.html
+++ b/runtime/observatory/lib/src/elements/field_view.html
@@ -12,12 +12,9 @@
<nav-bar>
<top-nav-menu></top-nav-menu>
<isolate-nav-menu isolate="{{ field.isolate }}"></isolate-nav-menu>
- <template if="{{ field.owner.type == 'Class' }}">
- <!-- TODO(turnidge): Add library nav menu here. -->
- <class-nav-menu cls="{{ field.owner }}"></class-nav-menu>
- </template>
- <template if="{{ field.owner.type == 'Library' }}">
- <library-nav-menu library="{{ field.owner }}"></library-nav-menu>
+ <library-nav-menu library="{{ field.library }}"></library-nav-menu>
+ <template if="{{ field.dartOwner is ServiceClass }}">
+ <class-nav-menu cls="{{ field.dartOwner }}"></class-nav-menu>
</template>
<nav-menu link="{{ makeLink('/inspect', field) }}" anchor="{{ field.name }}" last="{{ true }}"></nav-menu>
<nav-refresh callback="{{ refresh }}"></nav-refresh>
@@ -42,12 +39,7 @@
<div class="memberItem">
<div class="memberName">owner</div>
<div class="memberValue">
- <template if="{{ field.owner.type == 'Class' }}">
- <class-ref ref="{{ field.owner }}"></class-ref>
- </template>
- <template if="{{ field.owner.type != 'Class' }}">
- <library-ref ref="{{ field.owner }}"></library-ref>
- </template>
+ <any-service-ref ref="{{ function.dartOwner }}"></any-service-ref>
</div>
</div>
<div class="memberItem">
« no previous file with comments | « runtime/lib/isolate.cc ('k') | runtime/observatory/lib/src/elements/function_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698