Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1057303003: Remove 2 duplicated SVG tests and rename 3 SVG text tests for selection (Closed)

Created:
5 years, 8 months ago by jaemin86.seo
Modified:
5 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, kangil_
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove 2 duplicated SVG tests and rename 3 SVG text tests for selection This patch removes the following W3C-SVG-1.1 tests in favor of their duplicated versions in W3C-SVG-1.1-SE and renames the following SVG text tests because they are actually testing selection. The associated expectation files have been updated as well. Remove (W3C-SVG-1.1) 1. text-intro-02-b.svg 2. text-intro-05-t.svg 3. text-intro-02-b-expected.png 4. text-intro-02-b-expected.txt 5. text-intro-05-t-expected.png 6. text-intro-05-t-expected.txt Rename (text) 1. text-intro-05-t.svg -> text-selection-intro-05-t.svg 2. text-path-01-b.svg -> text-selection-path-01-b.svg 3. text-spacing-01-b.svg -> text-selection-spacing-01-b.svg 4. text-intro-05-t-expected.png -> text-selection-intro-05-t-expected.png 5. text-intro-05-t-expected.txt -> text-selection-intro-05-t-expected.txt 6. text-path-01-b-expected.png -> text-selection-path-01-b-expected.png 7. text-path-01-b-expected.txt -> text-selection-path-01-b-expected.txt 8. text-spacing-01-b-expected.png -> text-selection-spacing-01-b-expected.png 9. text-spacing-01-b-expected.txt -> text-selection-spacing-01-b-expected.txt BUG=477550 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194435

Patch Set 1 #

Patch Set 2 : Remove 2 duplicated SVG tests and rename 3 SVG text tests for reflecting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-19 lines, -1502 lines) Patch
D LayoutTests/platform/android/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/android/virtual/slimmingpaint/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-path-01-b-expected.txt View 1 1 chunk +0 lines, -98 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-intro-05-t-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-path-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-spacing-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/svg/text/text-selection-spacing-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/linux/svg/text/text-spacing-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/linux/svg/text/text-spacing-01-b-expected.txt View 1 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/linux/virtual/slimmingpaint/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/svg/W3C-SVG-1.1/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac-mountainlion/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-mountainlion/virtual/slimmingpaint/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac-mountainlion/virtual/slimmingpaint/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/W3C-SVG-1.1/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac-snowleopard/virtual/slimmingpaint/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/mac/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-path-01-b-expected.txt View 1 1 chunk +0 lines, -98 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-intro-05-t-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-path-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/svg/text/text-selection-spacing-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/svg/text/text-spacing-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-path-01-b-expected.txt View 1 1 chunk +0 lines, -98 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-intro-05-t-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-path-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-spacing-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-selection-spacing-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-spacing-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-spacing-01-b-expected.txt View 1 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/text-intro-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-path-01-b-expected.txt View 1 1 chunk +0 lines, -98 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-intro-05-t-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-path-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-spacing-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/svg/text/text-selection-spacing-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-spacing-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/svg/text/text-spacing-01-b-expected.txt View 1 1 chunk +0 lines, -68 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-path-01-b-expected.txt View 1 1 chunk +0 lines, -98 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-intro-05-t-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win-xp/virtual/slimmingpaint/svg/text/text-selection-path-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-02-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-intro-05-t-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-intro-05-t-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/platform/win/svg/text/text-path-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-path-01-b-expected.txt View 1 1 chunk +0 lines, -98 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-intro-05-t-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-intro-05-t-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-path-01-b-expected.png View 1 Binary file 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-path-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/win/svg/text/text-selection-spacing-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/svg/text/text-spacing-01-b-expected.png View 1 Binary file 0 comments Download
D LayoutTests/svg/W3C-SVG-1.1/text-intro-02-b.svg View 1 chunk +0 lines, -107 lines 0 comments Download
D LayoutTests/svg/W3C-SVG-1.1/text-intro-05-t.svg View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/svg/text/text-intro-05-t.svg View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/svg/text/text-path-01-b.svg View 1 chunk +0 lines, -88 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-intro-05-t.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-path-01-b.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-spacing-01-b.svg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/svg/text/text-selection-spacing-01-b-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/svg/text/text-spacing-01-b.svg View 1 chunk +0 lines, -59 lines 0 comments Download
D LayoutTests/svg/text/text-spacing-01-b-expected.txt View 1 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jaemin86.seo
PTAL
5 years, 8 months ago (2015-04-17 07:24:04 UTC) #2
pdr.
On 2015/04/17 at 07:24:04, jaemin86.seo wrote: > PTAL For the /text tests, please see my ...
5 years, 8 months ago (2015-04-18 03:18:39 UTC) #3
jaemin86.seo
PTAL :)
5 years, 8 months ago (2015-04-24 16:04:41 UTC) #5
pdr.
On 2015/04/24 at 16:04:41, jaemin86.seo wrote: > PTAL :) Excellent change description. LGTM
5 years, 8 months ago (2015-04-25 02:41:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057303003/40001
5 years, 8 months ago (2015-04-25 02:42:15 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-25 16:34:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194435

Powered by Google App Engine
This is Rietveld 408576698