Rename 5 SVG text tests to reflect that they are for selection.

Rename 5 SVG text tests to reflect that they are for selection.

This patch renames the following SVG text tests because they are
actually testing selection. The associated expectation files have
been updated as well. Belows are renamed files list.

1. text-text-01-b.svg -> text-selection-text-01-b.svg
2. text-text-03-b.svg -> text-selection-text-03-b.svg
3. text-text-04-t.svg -> text-selection-text-04-t.svg
4. text-text-05-t.svg -> text-selection-text-05-t.svg
5. text-text-06-t.svg -> text-selection-text-06-t.svg
6. text-text-01-b-expected.png -> text-selection-text-01-b-expected.png
7. text-text-01-b-expected.txt -> text-selection-text-01-b-expected.txt
8. text-text-03-b-expected.png -> text-selection-text-03-b-expected.png
9. text-text-03-b-expected.txt -> text-selection-text-03-b-expected.txt
10. text-text-04-t-expected.png -> text-selection-text-04-t-expected.png
11. text-text-04-t-expected.txt -> text-selection-text-04-t-expected.txt
12. text-text-05-t-expected.png -> text-selection-text-05-t-expected.png
13. text-text-05-t-expected.txt -> text-selection-text-05-t-expected.txt
14. text-text-06-t-expected.png -> text-selection-text-06-t-expected.png
15. text-text-06-t-expected.txt -> text-selection-text-06-t-expected.txt

BUG=477550
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194425

[jaemin86.seo, 2015-04-17 07:24:29]

jaemin86.seo@samsung.com changed reviewers:
+ pdr@google.com

[jaemin86.seo, 2015-04-17 07:24:30]

PTAL

[jaemin86.seo, 2015-04-17 07:54:04]

jaemin86.seo@samsung.com changed reviewers:
+ pdr@chromium.org
- pdr@google.com

[pdr., 2015-04-18 03:16:13]

Please use a better change description. Something like the following:

---------8<---------
Rename 5 SVG text tests to reflect that they are for selection.

This patch renames the following SVG text tests because they are
actually testing selection. The associated expectation files have
been updated as well.

1. text-text-01-b.svg -> text-selection-text-01-b.svg
2. ... etc

BUG=477550
---------8<---------

Also make sure to wrap the change description at 72 lines.

https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
File LayoutTests/svg/text/text-text-01-b.svg (left):

https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
LayoutTests/svg/text/text-text-01-b.svg:211: if (window.testRunner)
Please review these differences closely. It looks like this test is genuinely
different from LayoutTests/svg/W3C-SVG-1.1/text-text-01-b.svg because of this
text selection code. Using "git log LayoutTests/svg/text/text-text-01-b.svg", I
confirmed these tests were added to test selection.

Lets not remove these after all. Instead, we can rename them with the
"selection-" prefix such as "LayoutTests/svg/text/text-selection-text-03-b.svg".
Be sure to rename the associated expectations as well:
./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.png
./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.txt
./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.png
./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.txt
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.png
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.txt
./LayoutTests/platform/win/svg/text/text-text-01-b-expected.png
./LayoutTests/platform/win/svg/text/text-text-01-b-expected.txt
./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.png
./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.txt

[jaemin86.seo, 2015-04-20 05:07:23]

On 2015/04/18 03:16:13, pdr (OOO April 18th to 22nd) wrote:
> Please use a better change description. Something like the following:
> 
> ---------8<---------
> Rename 5 SVG text tests to reflect that they are for selection.
> 
> This patch renames the following SVG text tests because they are
> actually testing selection. The associated expectation files have
> been updated as well.
> 
> 1. text-text-01-b.svg -> text-selection-text-01-b.svg
> 2. ... etc
> 
> BUG=477550
> ---------8<---------
> 
> Also make sure to wrap the change description at 72 lines.
> 
>
https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
> File LayoutTests/svg/text/text-text-01-b.svg (left):
> 
>
https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
> LayoutTests/svg/text/text-text-01-b.svg:211: if (window.testRunner)
> Please review these differences closely. It looks like this test is genuinely
> different from LayoutTests/svg/W3C-SVG-1.1/text-text-01-b.svg because of this
> text selection code. Using "git log LayoutTests/svg/text/text-text-01-b.svg",
I
> confirmed these tests were added to test selection.
> 
> Lets not remove these after all. Instead, we can rename them with the
> "selection-" prefix such as
"LayoutTests/svg/text/text-selection-text-03-b.svg".
> Be sure to rename the associated expectations as well:
> ./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.png
> ./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.txt
> ./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.png
> ./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.txt
>
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.png
>
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.txt
> ./LayoutTests/platform/win/svg/text/text-text-01-b-expected.png
> ./LayoutTests/platform/win/svg/text/text-text-01-b-expected.txt
> ./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.png
> ./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.txt

Thank you for your kind review.
I have a question about your review.

"Also make sure to wrap the change description at 72 lines."
This comment means 72 line 'to "spacing".' in the text-text-01-b.svg file should
be wrapped in 71 line?
Or lines means characters?

[pdr., 2015-04-24 04:45:04]

On 2015/04/20 at 05:07:23, jaemin86.seo wrote:
> On 2015/04/18 03:16:13, pdr (OOO April 18th to 22nd) wrote:
> > Please use a better change description. Something like the following:
> > 
> > ---------8<---------
> > Rename 5 SVG text tests to reflect that they are for selection.
> > 
> > This patch renames the following SVG text tests because they are
> > actually testing selection. The associated expectation files have
> > been updated as well.
> > 
> > 1. text-text-01-b.svg -> text-selection-text-01-b.svg
> > 2. ... etc
> > 
> > BUG=477550
> > ---------8<---------
> > 
> > Also make sure to wrap the change description at 72 lines.
> > 
> >
https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
> > File LayoutTests/svg/text/text-text-01-b.svg (left):
> > 
> >
https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
> > LayoutTests/svg/text/text-text-01-b.svg:211: if (window.testRunner)
> > Please review these differences closely. It looks like this test is
genuinely
> > different from LayoutTests/svg/W3C-SVG-1.1/text-text-01-b.svg because of
this
> > text selection code. Using "git log
LayoutTests/svg/text/text-text-01-b.svg", I
> > confirmed these tests were added to test selection.
> > 
> > Lets not remove these after all. Instead, we can rename them with the
> > "selection-" prefix such as
"LayoutTests/svg/text/text-selection-text-03-b.svg".
> > Be sure to rename the associated expectations as well:
> > ./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.png
> > ./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.txt
> > ./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.png
> > ./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.txt
> >
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.png
> >
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.txt
> > ./LayoutTests/platform/win/svg/text/text-text-01-b-expected.png
> > ./LayoutTests/platform/win/svg/text/text-text-01-b-expected.txt
> > ./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.png
> > ./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.txt
> 
> Thank you for your kind review.
> I have a question about your review.
> 
> "Also make sure to wrap the change description at 72 lines."
> This comment means 72 line 'to "spacing".' in the text-text-01-b.svg file
should be wrapped in 71 line?
> Or lines means characters?

Oh, I'm sorry, this was just a general comment to wrap change descriptions at 72
characters. The test files are fine.


For example, if your change description is:
---------8<---------
Fix the spurving bearings.

This patch fixes a bug in the turboencabulator's pre-famulated amulite casing in
such a way that the two spurving bearings release quickly.

See http://en.wikipedia.org/wiki/Turboencabulator for details.

BUG=12345
---------8<---------



You should could change it to:
---------8<---------
Fix the spurving bearings.

This patch fixes a bug in the turboencabulator's pre-famulated amulite
casing in such a way that the two spurving bearings release quickly.

See http://en.wikipedia.org/wiki/Turboencabulator for details.

BUG=12345
---------8<---------

[jaemin86.seo, 2015-04-24 05:01:17]

On 2015/04/24 04:45:04, pdr (OOO April 18th to 22nd) wrote:
> On 2015/04/20 at 05:07:23, jaemin86.seo wrote:
> > On 2015/04/18 03:16:13, pdr (OOO April 18th to 22nd) wrote:
> > > Please use a better change description. Something like the following:
> > > 
> > > ---------8<---------
> > > Rename 5 SVG text tests to reflect that they are for selection.
> > > 
> > > This patch renames the following SVG text tests because they are
> > > actually testing selection. The associated expectation files have
> > > been updated as well.
> > > 
> > > 1. text-text-01-b.svg -> text-selection-text-01-b.svg
> > > 2. ... etc
> > > 
> > > BUG=477550
> > > ---------8<---------
> > > 
> > > Also make sure to wrap the change description at 72 lines.
> > > 
> > >
>
https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
> > > File LayoutTests/svg/text/text-text-01-b.svg (left):
> > > 
> > >
>
https://codereview.chromium.org/1049863003/diff/1/LayoutTests/svg/text/text-t...
> > > LayoutTests/svg/text/text-text-01-b.svg:211: if (window.testRunner)
> > > Please review these differences closely. It looks like this test is
> genuinely
> > > different from LayoutTests/svg/W3C-SVG-1.1/text-text-01-b.svg because of
> this
> > > text selection code. Using "git log
> LayoutTests/svg/text/text-text-01-b.svg", I
> > > confirmed these tests were added to test selection.
> > > 
> > > Lets not remove these after all. Instead, we can rename them with the
> > > "selection-" prefix such as
> "LayoutTests/svg/text/text-selection-text-03-b.svg".
> > > Be sure to rename the associated expectations as well:
> > > ./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.png
> > > ./LayoutTests/platform/linux/svg/text/text-text-01-b-expected.txt
> > > ./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.png
> > > ./LayoutTests/platform/mac/svg/text/text-text-01-b-expected.txt
> > >
>
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.png
> > >
>
./LayoutTests/platform/mac/virtual/slimmingpaint/svg/text/text-text-01-b-expected.txt
> > > ./LayoutTests/platform/win/svg/text/text-text-01-b-expected.png
> > > ./LayoutTests/platform/win/svg/text/text-text-01-b-expected.txt
> > > ./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.png
> > > ./LayoutTests/platform/win-xp/svg/text/text-text-01-b-expected.txt
> > 
> > Thank you for your kind review.
> > I have a question about your review.
> > 
> > "Also make sure to wrap the change description at 72 lines."
> > This comment means 72 line 'to "spacing".' in the text-text-01-b.svg file
> should be wrapped in 71 line?
> > Or lines means characters?
> 
> Oh, I'm sorry, this was just a general comment to wrap change descriptions at
72
> characters. The test files are fine.
> 
> 
> For example, if your change description is:
> ---------8<---------
> Fix the spurving bearings.
> 
> This patch fixes a bug in the turboencabulator's pre-famulated amulite casing
in
> such a way that the two spurving bearings release quickly.
> 
> See http://en.wikipedia.org/wiki/Turboencabulator for details.
> 
> BUG=12345
> ---------8<---------
> 
> 
> 
> You should could change it to:
> ---------8<---------
> Fix the spurving bearings.
> 
> This patch fixes a bug in the turboencabulator's pre-famulated amulite
> casing in such a way that the two spurving bearings release quickly.
> 
> See http://en.wikipedia.org/wiki/Turboencabulator for details.
> 
> BUG=12345
> ---------8<---------

Thank you for your answer :)
I'll update new patch set today.

[jaemin86.seo, 2015-04-24 16:05:19]

PTAL :)

[pdr., 2015-04-24 22:12:00]

LGTM

[pdr., 2015-04-24 22:12:02]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-04-24 22:12:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049863003/20001

[commit-bot: I haz the power, 2015-04-25 01:19:50]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194425