Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1509)

Issue 1057213003: Java: Introduce ResultAnd<> and use it. (Closed)

Created:
5 years, 8 months ago by qsr
Modified:
5 years, 8 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Java: Introduce ResultAnd<> and use it. Never overload an int to be either a MojoResult or something else. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2c40ae03889a9c3e37c717c12db746993639e8d1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -259 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/HandleMock.java View 4 chunks +8 lines, -9 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/ConnectorTest.java View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/bindings/RouterTest.java View 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java View 10 chunks +38 lines, -30 lines 0 comments Download
M mojo/android/system/core_impl.cc View 8 chunks +23 lines, -30 lines 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java View 14 chunks +71 lines, -144 lines 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/DataPipeConsumerHandleImpl.java View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/DataPipeProducerHandleImpl.java View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/MessagePipeHandleImpl.java View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/java/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Connector.java View 2 chunks +9 lines, -5 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/DataPipe.java View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/InvalidHandle.java View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/java/system/src/org/chromium/mojo/system/MessagePipeHandle.java View 3 chunks +2 lines, -20 lines 0 comments Download
A mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java View 1 chunk +34 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
qsr
5 years, 8 months ago (2015-04-03 13:56:36 UTC) #1
etiennej
LGTM https://codereview.chromium.org/1057213003/diff/1/mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java File mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java (right): https://codereview.chromium.org/1057213003/diff/1/mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java#newcode12 mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java:12: public class ResultAnd<A> { (very optional) Something I've ...
5 years, 8 months ago (2015-04-03 14:18:20 UTC) #2
qsr
https://codereview.chromium.org/1057213003/diff/1/mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java File mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java (right): https://codereview.chromium.org/1057213003/diff/1/mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java#newcode12 mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java:12: public class ResultAnd<A> { On 2015/04/03 14:18:20, etiennej wrote: ...
5 years, 8 months ago (2015-04-03 14:32:54 UTC) #3
qsr
5 years, 8 months ago (2015-04-03 14:33:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c40ae03889a9c3e37c717c12db746993639e8d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698