mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java - Issue 1057213003: Java: Introduce ResultAnd<> and use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java

Issue 1057213003: Java: Introduce ResultAnd<> and use it. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/java/bindings/src/org/chromium/mojo/bindings/Connector.java ('k') | mojo/public/java/system/src/org/chromium/mojo/system/DataPipe.java » ('j') | mojo/public/java/system/src/org/chromium/mojo/system/ResultAnd.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java

diff --git a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java

index d0d5c3bcf211dc495d765c4c6cacb6885af9fcea..e24c96684e81e4be25e99dc95cd3f32c640c18b6 100644

--- a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java

+++ b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/ExecutorFactory.java

@@ -12,6 +12,7 @@ import org.chromium.mojo.system.MessagePipeHandle.ReadMessageResult;

import org.chromium.mojo.system.MojoException;

import org.chromium.mojo.system.MojoResult;

import org.chromium.mojo.system.Pair;

+import org.chromium.mojo.system.ResultAnd;

import java.nio.ByteBuffer;

import java.util.ArrayList;

@@ -122,8 +123,8 @@ class ExecutorFactory {

private boolean readNotifyBufferMessage() {

try {

- ReadMessageResult readMessageResult = mReadHandle.readMessage(NOTIFY_BUFFER, 0,

- MessagePipeHandle.ReadFlags.NONE);

+ ResultAnd<ReadMessageResult> readMessageResult =

+ mReadHandle.readMessage(NOTIFY_BUFFER, 0, MessagePipeHandle.ReadFlags.NONE);

if (readMessageResult.getMojoResult() == MojoResult.OK) {

asyncWait();

return true;