Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1057193003:
Permissions: add UMA for navigator.permissions.query() usage. (Closed)
|
Created:
5 years, 8 months ago by mlamouri (slow - plz ping) Modified:
5 years, 8 months ago Reviewers:
philipj_slow CC:
blink-reviews Base URL:
https://chromium.googlesource.com/chromium/blink.git@permissions_required Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionPermissions: add UMA for navigator.permissions.query() usage.
BUG=474692
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193298
Patch Set 1 #
Total comments: 2
Patch Set 2 : use default name #Patch Set 3 : rebase #
Messages
Total messages: 21 (10 generated)
mlamouri@chromium.org changed reviewers: + philipj@opera.com
LGTM % [Measure] syntax https://codereview.chromium.org/1057193003/diff/1/Source/modules/permissions/... File Source/modules/permissions/Permissions.idl (right): https://codereview.chromium.org/1057193003/diff/1/Source/modules/permissions/... Source/modules/permissions/Permissions.idl:13: [CallWith=ScriptState, MeasureAs=PermissionsQuery] Promise<PermissionStatus> query(object permission); As of https://codereview.chromium.org/877523004 it's possible to simply use [Measure], which generates the name. I'd use it wherever possible.
The CQ bit was checked by mlamouri@chromium.org
https://codereview.chromium.org/1057193003/diff/1/Source/modules/permissions/... File Source/modules/permissions/Permissions.idl (right): https://codereview.chromium.org/1057193003/diff/1/Source/modules/permissions/... Source/modules/permissions/Permissions.idl:13: [CallWith=ScriptState, MeasureAs=PermissionsQuery] Promise<PermissionStatus> query(object permission); On 2015/04/03 at 16:49:39, philipj_UTC7 wrote: > As of https://codereview.chromium.org/877523004 it's possible to simply use [Measure], which generates the name. I'd use it wherever possible. Done.
The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com Link to the patchset: https://codereview.chromium.org/1057193003/#ps20001 (title: "use default name")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057193003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50437)
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057193003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50492)
The CQ bit was checked by mlamouri@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057193003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...) mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50821)
The CQ bit was checked by mlamouri@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com Link to the patchset: https://codereview.chromium.org/1057193003/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057193003/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=193298 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
