Source/modules/permissions/Permissions.idl - Issue 1057193003: Permissions: add UMA for navigator.permissions.query() usage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/permissions/Permissions.idl

Issue 1057193003: Permissions: add UMA for navigator.permissions.query() usage. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@permissions_required

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Specification at:	5 // Specification at:

6 // https://w3c.github.io/permissions/	6 // https://w3c.github.io/permissions/

7	7

8 [	8 [

9 Exposed=(Window,Worker),	9 Exposed=(Window,Worker),

10 GarbageCollected,	10 GarbageCollected,

11 RuntimeEnabled=Permissions	11 RuntimeEnabled=Permissions

12 ] interface Permissions {	12 ] interface Permissions {

13 [CallWith=ScriptState] Promise<PermissionStatus> query(object permission);	13 [CallWith=ScriptState, MeasureAs=PermissionsQuery] Promise<PermissionStatus> query(object permission);
	philipj_slow 2015/04/03 16:49:39 As of https://codereview.chromium.org/877523004 it As of https://codereview.chromium.org/877523004 it's possible to simply use [Measure], which generates the name. I'd use it wherever possible. mlamouri (slow - plz ping) 2015/04/03 17:49:48 Done. Show quoted text On 2015/04/03 at 16:49:39, philipj_UTC7 wrote: > As of https://codereview.chromium.org/877523004 it's possible to simply use [Measure], which generates the name. I'd use it wherever possible. Done.
14 };	14 };

OLD	NEW

« no previous file with comments | « Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »