Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(561)

Issue 1057083002: Fix menu list and list box screen reader accessibility. (Closed)

Created:
5 years, 8 months ago by dmazzoni
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix menu list and list box screen reader accessibility. The most important change here is getting rid of code in renderer_accessibility.cc that recreated the subtree whenever AXSelectedChildrenChanged was fired. This is no longer necessary because Blink now fires the right events on each individual option in a menu list or list box. The rest of the changes just make sure the exact attributes and events match the spec and match what Firefox and Safari do when interacting with these elements, including adding some good tests for those. BUG=323462 Committed: https://crrev.com/9dbb3741802d2a5a3f6370fef9d712b077fa4b86 Cr-Commit-Position: refs/heads/master@{#326755}

Patch Set 1 #

Patch Set 2 : Tests pass on Windows #

Patch Set 3 : Fix on Mac too #

Total comments: 2

Patch Set 4 : Rebase #

Patch Set 5 : Fix a few tests #

Patch Set 6 : Fix Mac test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -56 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 1 chunk +30 lines, -16 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 2 3 4 5 3 chunks +18 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 5 5 chunks +43 lines, -9 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 4 5 1 chunk +0 lines, -7 lines 0 comments Download
A content/test/data/accessibility/event/listbox-focus.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/listbox-focus-expected-mac.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/listbox-focus-expected-win.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/listbox-next.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/listbox-next-expected-mac.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/listbox-next-expected-win.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/menulist-focus.html View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/menulist-focus-expected-mac.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/menulist-focus-expected-win.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/menulist-next.html View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/menulist-next-expected-mac.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/menulist-next-expected-win.txt View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/data/accessibility/html/keygen.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/html/keygen-expected-win.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/html/modal-dialog-closed-expected-win.txt View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/data/accessibility/html/select-expected-win.txt View 1 2 3 4 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
dmazzoni
Depends on this Blink change in order for the tests to pass: https://codereview.chromium.org/1059503002/
5 years, 8 months ago (2015-04-06 07:09:58 UTC) #2
je_julie(Not used)
lgtm https://codereview.chromium.org/1057083002/diff/40001/content/browser/accessibility/browser_accessibility_manager_mac.mm File content/browser/accessibility/browser_accessibility_manager_mac.mm (right): https://codereview.chromium.org/1057083002/diff/40001/content/browser/accessibility/browser_accessibility_manager_mac.mm#newcode66 content/browser/accessibility/browser_accessibility_manager_mac.mm:66: node->GetParent()->GetRole() == ui::AX_ROLE_LIST_BOX) { For this condition, how ...
5 years, 8 months ago (2015-04-06 10:31:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057083002/60001
5 years, 8 months ago (2015-04-23 18:22:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/76772)
5 years, 8 months ago (2015-04-23 19:51:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057083002/80001
5 years, 8 months ago (2015-04-23 22:59:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/58793)
5 years, 8 months ago (2015-04-24 02:36:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057083002/100001
5 years, 8 months ago (2015-04-24 07:17:11 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/30735)
5 years, 8 months ago (2015-04-24 07:23:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1057083002/100001
5 years, 8 months ago (2015-04-24 07:51:43 UTC) #20
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 8 months ago (2015-04-24 08:22:28 UTC) #21
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 08:23:31 UTC) #22
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/9dbb3741802d2a5a3f6370fef9d712b077fa4b86
Cr-Commit-Position: refs/heads/master@{#326755}

Powered by Google App Engine
This is Rietveld 408576698