|
Fix menu list and list box screen reader accessibility.
The most important change here is getting rid of code in
renderer_accessibility.cc that recreated the subtree whenever
AXSelectedChildrenChanged was fired. This is no longer
necessary because Blink now fires the right events on each
individual option in a menu list or list box.
The rest of the changes just make sure the exact attributes
and events match the spec and match what Firefox and
Safari do when interacting with these elements, including
adding some good tests for those.
BUG= 323462
Committed: https://crrev.com/9dbb3741802d2a5a3f6370fef9d712b077fa4b86
Cr-Commit-Position: refs/heads/master@{#326755}
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+226 lines, -56 lines) |
Patch |
 |
M |
content/browser/accessibility/browser_accessibility_cocoa.mm
|
View
|
1
2
3
4
5
|
1 chunk |
+30 lines, -16 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager_mac.mm
|
View
|
1
2
3
4
5
|
3 chunks |
+18 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager_win.cc
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_win.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_win.cc
|
View
|
1
2
3
4
5
|
5 chunks |
+43 lines, -9 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/dump_accessibility_events_browsertest.cc
|
View
|
1
|
1 chunk |
+20 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/renderer/accessibility/blink_ax_enum_conversion.cc
|
View
|
1
2
3
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/renderer/accessibility/renderer_accessibility.cc
|
View
|
4
5
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/listbox-focus.html
|
View
|
1
2
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/listbox-focus-expected-mac.txt
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/listbox-focus-expected-win.txt
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/listbox-next.html
|
View
|
1
2
|
1 chunk |
+19 lines, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/listbox-next-expected-mac.txt
|
View
|
1
2
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/listbox-next-expected-win.txt
|
View
|
1
|
1 chunk |
+6 lines, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/menulist-focus.html
|
View
|
1
2
|
1 chunk |
+18 lines, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/menulist-focus-expected-mac.txt
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/menulist-focus-expected-win.txt
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/menulist-next.html
|
View
|
1
2
|
1 chunk |
+19 lines, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/menulist-next-expected-mac.txt
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
A |
content/test/data/accessibility/event/menulist-next-expected-win.txt
|
View
|
1
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/html/keygen.html
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/html/keygen-expected-win.txt
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/html/modal-dialog-closed-expected-win.txt
|
View
|
1
2
3
4
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/html/select-expected-win.txt
|
View
|
1
2
3
4
|
1 chunk |
+12 lines, -12 lines |
0 comments
|
Download
|
Total messages: 22 (11 generated)
|