content/renderer/accessibility/renderer_accessibility.cc - Issue 1057083002: Fix menu list and list box screen reader accessibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/renderer_accessibility.cc

Issue 1057083002: Fix menu list and list box screen reader accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Mac test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/accessibility/blink_ax_enum_conversion.cc ('k') | content/test/data/accessibility/event/listbox-focus.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/renderer_accessibility.cc

diff --git a/content/renderer/accessibility/renderer_accessibility.cc b/content/renderer/accessibility/renderer_accessibility.cc

index b8152bac21e896b281d16e09ec84e0fc6c121140..0c57f6d7bb76406103e11fff157761445cc77d91 100644

--- a/content/renderer/accessibility/renderer_accessibility.cc

+++ b/content/renderer/accessibility/renderer_accessibility.cc

@@ -235,13 +235,6 @@ void RendererAccessibility::SendPendingAccessibilityEvents() {

if (!tree_source_.IsInTree(obj))

continue;

- // When we get a "selected children changed" event, Blink

- // doesn't also send us events for each child that changed

- // selection state, so make sure we re-send that whole subtree.

- if (event.event_type == ui::AX_EVENT_SELECTED_CHILDREN_CHANGED) {

- serializer_.DeleteClientSubtree(obj);

- }

AccessibilityHostMsg_EventParams event_msg;

tree_source_.CollectChildFrameIdMapping(

&event_msg.node_to_frame_routing_id_map,